Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-label PRs based on their content [skip-ci] #7044

Merged
merged 8 commits into from
Feb 8, 2021
Merged

Auto-label PRs based on their content [skip-ci] #7044

merged 8 commits into from
Feb 8, 2021

Conversation

jolorunyomi
Copy link
Contributor

@jolorunyomi jolorunyomi commented Dec 22, 2020 •
edited by mike-wendt
Loading

This PR adds the GitHub action PR Labeler to auto-label PRs based on their content.

Labeling is managed with a configuration file .github/labeler.yml using the following options.

@jolorunyomi jolorunyomi requested a review from a team as a code owner December 22, 2020 16:53
@jolorunyomi jolorunyomi changed the base branch from branch-0.17 to branch-0.18 December 22, 2020 16:59
@jolorunyomi jolorunyomi added the feature request New feature or request label Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020 •
edited
Loading

Codecov Report

Merging #7044 (096f502) into branch-0.18 (00ca246) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7044      +/-   ##
===============================================
+ Coverage        81.95%   82.20%   +0.25%     
===============================================
  Files               96       98       +2     
  Lines            16294    16692     +398     
===============================================
+ Hits             13353    13722     +369     
- Misses            2941     2970      +29
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/groupby.py 92.15% <0.00%> (-2.90%) ⬇️
python/cudf/cudf/io/csv.py 91.66% <0.00%> (-2.34%) ⬇️
python/cudf/cudf/io/orc.py 86.89% <0.00%> (-1.51%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.85% <0.00%> (-1.45%) ⬇️
python/cudf/cudf/core/dtypes.py 89.94% <0.00%> (-0.45%) ⬇️
python/cudf/cudf/core/column/methods.py 96.00% <0.00%> (-0.43%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.13% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/core/column/timedelta.py 89.16% <0.00%> (-0.38%) ⬇️
python/cudf/cudf/core/dataframe.py 90.49% <0.00%> (-0.28%) ⬇️
python/cudf/cudf/core/series.py 91.10% <0.00%> (-0.19%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ca246...3b4fa30. Read the comment docs.

ajschmidt8
ajschmidt8 requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this. I think that the file/path patterns will need to be re-reviewed and adjusted according to the actions/labeler README though.

.github/labeler.yml Outdated Show resolved Hide resolved
@harrism
Copy link
Member

harrism commented Jan 5, 2021

This PR needs a description of what is in the PR.

@mike-wendt
Copy link
Contributor

This PR needs a description of what is in the PR.

@jolorunyomi can you update this PR and others with a description of what it is addressing? This way it can be auto-merged and saved in the update log?

@mike-wendt mike-wendt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed feature request New feature or request labels Jan 6, 2021
mike-wendt
mike-wendt suggested changes Jan 21, 2021
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
@mike-wendt
Copy link
Contributor

@kkraus14 @harrism can you review this labeler config to suggest or add any other labels you would like to see automatically added for cudf?

kkraus14
kkraus14 reviewed Jan 21, 2021
View reviewed changes
.github/labeler.yml Show resolved Hide resolved
.github/labeler.yml Show resolved Hide resolved
mike-wendt
mike-wendt reviewed Jan 21, 2021
View reviewed changes
.github/labeler.yml Outdated
Comment on lines 23 to 25
- '**/Dockerfile'
- '**/.dockerignore'
- 'docker/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be dropped

mike-wendt
mike-wendt reviewed Jan 21, 2021
View reviewed changes
.github/labeler.yml Outdated
Comment on lines 19 to 20
Ops:
- '.github/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop these

kkraus14
kkraus14 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

mike-wendt
mike-wendt suggested changes Jan 25, 2021
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated
- 'python/**'
- 'notebooks/**'

cpp:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkraus14 should this label be libcudf or libcudf++? Or do you prefer a new label here of cpp? Just trying to match to an existing label and cpp is not one currently

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libcudf if we want to match an existing label

@mike-wendt mike-wendt changed the title add Pull Request Labeler configuration Add PR auto-labeler based on content [skip-ci] Jan 25, 2021
@mike-wendt mike-wendt removed the request for review from harrism January 25, 2021 20:10
@mike-wendt mike-wendt changed the title Add PR auto-labeler based on content [skip-ci] Auto-label PRs based on their content [skip-ci] Jan 28, 2021
@harrism
Copy link
Member

harrism commented Feb 3, 2021

Is this ready to merge once CI passes? @jolorunyomi @mike-wendt

@mike-wendt
Copy link
Contributor

with [skip-ci] this will just stay pending - there is no way to change the statuses for this commit so we need an updated commit

@harrism
Copy link
Member

harrism commented Feb 8, 2021

with [skip-ci] this will just stay pending - there is no way to change the statuses for this commit so we need an updated commit

That's fine, can you please take ownership of getting this PR merged? I don't know whether it is ready.

harrism
harrism reviewed Feb 8, 2021
View reviewed changes
.github/labeler.yml Outdated Show resolved Hide resolved
@mike-wendt @harrism
DOC Fix spelling
3b4fa30 
Co-authored-by: Mark Harris <mharris@nvidia.com>
@mike-wendt
Copy link
Contributor

This should pass shortly and can be merged with the bot command as it will pass all checks in a few mins

@mike-wendt
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a86d5dd into branch-0.18 Feb 8, 2021
@mike-wendt mike-wendt deleted the pr-labeler branch February 8, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@harrism harrism harrism left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@mike-wendt mike-wendt mike-wendt approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jolorunyomi @harrism @mike-wendt @kkraus14 @ajschmidt8