-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing stream to scalar.is_valid() wherever stream is available #9436
add missing stream to scalar.is_valid() wherever stream is available #9436
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9436 +/- ##
================================================
+ Coverage 10.79% 10.80% +0.01%
================================================
Files 116 117 +1
Lines 18869 19425 +556
================================================
+ Hits 2036 2098 +62
- Misses 16833 17327 +494
Continue to review full report at Codecov.
|
rerun tests |
@gpucibot merge |
Minor cleanup to utilize stream in scalar.is_valid()
Running scalar.is_valid() on default stream will be blocking all streams until that cudaMemcpy is complete. So, in future when multiple stream are used, this will cause unnecessary global stream sync.