Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing stream to scalar.is_valid() wherever stream is available #9436

Merged

Conversation

karthikeyann
Copy link
Contributor

Minor cleanup to utilize stream in scalar.is_valid()

Running scalar.is_valid() on default stream will be blocking all streams until that cudaMemcpy is complete. So, in future when multiple stream are used, this will cause unnecessary global stream sync.

@karthikeyann karthikeyann requested a review from a team as a code owner October 14, 2021 06:24
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 14, 2021
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue tech debt labels Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9436 (99f7ada) into branch-21.12 (ab4bfaa) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 99f7ada differs from pull request most recent head 1762f27. Consider uploading reports for the commit 1762f27 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9436      +/-   ##
================================================
+ Coverage         10.79%   10.80%   +0.01%     
================================================
  Files               116      117       +1     
  Lines             18869    19425     +556     
================================================
+ Hits               2036     2098      +62     
- Misses            16833    17327     +494     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 0.00% <ø> (ø)
python/dask_cudf/dask_cudf/sorting.py 93.52% <0.00%> (-0.60%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcb3e8...1762f27. Read the comment docs.

@karthikeyann
Copy link
Contributor Author

rerun tests

@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Oct 15, 2021
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8acf0dd into rapidsai:branch-21.12 Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants