This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Use pre-commit to enforce Python style checks #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awthomp
added
improvement
|
@ajschmidt8 -- You might be best to review and merge this PR, AJ! |
ajschmidt8
approved these changes
Apr 21, 2022
|
@awthomp, this PR looks good. It will still require an approval from you to satisfy the |
awthomp
approved these changes
Apr 21, 2022
|
@charlesbluca, let me know if this is all set to merge. feel free to merge if you have permissions |
|
@gpucibot merge |
|
@ajschmidt8 yeah think you or @awthomp will need to merge this one in |
|
Actually, totally forgot that I should merge in the latest changes - I will do that first and then this should be good |
|
@gpucibot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit configuration to this repo to enforce the Python style checks - it also modifies the gpuCI style check to use pre-commit instead of just
isort.The pre-commit configuration can probably be expanded to include CUDA style enforcement with
clang-format, but this seemed like a decent starting point.