This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Fix pinned buffer IO issues #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awthomp
added
improvement
awthomp
approved these changes
Apr 20, 2022
|
@gpucibot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve pinned buffer IO issues introduced in de9be48; essentially, if
read_binis passed abufferanddtype, it should prioritizebuffer.dtypeoverdtypeto ensure that the buffer and memmap sizes match up.Still want to add IO tests to ensure that things are working properly, and potentially alter
read_binto raise an error if bothbufferanddtypeare provided.Closes #474