Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Use conda to build python packages during GPU tests #480

Merged
merged 1 commit into from
May 11, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Apr 21, 2022

This PR convert the from sources build we are doing in GPU test job to a conda build. This is done for the following reasons:

  • This is required step to improve the Ops CI/CD setup to a more convenient pipeline
  • This is required to start using conda compilers and mamba to build RAPIDS packages
  • This prevent us from manually managing and installing the dependencies in GPU job
  • This ensure the packages can be installed
  • This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested.

This may increase the global pipeline time, but the usage of mamba should resolve this as mamba is faster than conda to build packages

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function 5 - DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Apr 21, 2022
@jjacobelli jjacobelli requested a review from a team as a code owner April 21, 2022 13:19
@jjacobelli jjacobelli self-assigned this Apr 21, 2022
@jjacobelli jjacobelli requested a review from a team as a code owner April 21, 2022 13:19
@jjacobelli jjacobelli marked this pull request as draft April 21, 2022 13:19
@jjacobelli jjacobelli removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 25, 2022
@jjacobelli jjacobelli marked this pull request as ready for review April 25, 2022 09:39
ci/gpu/build.sh Outdated Show resolved Hide resolved
@jjacobelli jjacobelli force-pushed the remove-from-sources branch 2 times, most recently from 41fb596 to 08cdae6 Compare May 10, 2022 11:22
@github-actions github-actions bot added the conda label May 10, 2022
@@ -9,7 +9,7 @@ package:
version: {{ version }}

source:
path: ../../..
git_url: ../../..
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required to prevent this issue:

AssertionError: Can't merge/copy source into subdirectory of itself.  Please create separate spaces for these things.
  src: /workspace
  dst: /workspace/.conda-bld/work

@jjacobelli jjacobelli force-pushed the remove-from-sources branch 4 times, most recently from 39da147 to 54d244a Compare May 10, 2022 13:25
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 07289a1 into rapidsai:branch-22.06 May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants