Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Add GitHub Actions Workflows #528

Merged
merged 25 commits into from
Dec 29, 2022
Merged

Add GitHub Actions Workflows #528

merged 25 commits into from
Dec 29, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 22, 2022

This PR adds GitHub Actions workflows to cusignal.

Task list

Coverage required for this PR:

  • Conda build
  • Python tests
  • Notebook tests
  • Style checks

Future work:

  • Some cleanup is needed of the existing conda environments, which seem outdated. I didn't want to delete them in this PR.

@github-actions github-actions bot added the conda label Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@0531015). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02     #528   +/-   ##
===============================================
  Coverage                ?   71.70%           
===============================================
  Files                   ?       51           
  Lines                   ?     2859           
  Branches                ?        0           
===============================================
  Hits                    ?     2050           
  Misses                  ?      809           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 26, 2022
@ajschmidt8 ajschmidt8 changed the title Add GitHub Actions Workflows. [skip gpuci] Add GitHub Actions Workflows Dec 26, 2022
@ajschmidt8
Copy link
Member

rerun tests

`cusignal` is a pure Python package, so it doesn't have a compilation step like some other RAPIDS libs.

therefore, many of these compilation related dependencies and environment variables can be removed.
@ajschmidt8 ajschmidt8 changed the title Add GitHub Actions Workflows Add GitHub Actions Workflows [skip gpuci] Dec 27, 2022
it looks like this notebook test requires a connection to an external device.

the job fails in CI since this device isn't available
this notebook requires a 26GB dataset, which takes a long time to download in CI
it looks like this notebook test requires a connection to an external device.

the job fails in CI since this device isn't available
@ajschmidt8 ajschmidt8 changed the title Add GitHub Actions Workflows [skip gpuci] Add GitHub Actions Workflows Dec 27, 2022
@ajschmidt8
Copy link
Member

rerun tests

dependencies.yaml Outdated Show resolved Hide resolved
@ajschmidt8 ajschmidt8 marked this pull request as ready for review December 29, 2022 15:37
@ajschmidt8 ajschmidt8 requested review from a team as code owners December 29, 2022 15:37
@ajschmidt8 ajschmidt8 merged commit 373235c into rapidsai:branch-23.02 Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants