Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Build CUDA 11.8 and Python 3.10 Packages #533

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 6, 2023

Description

This PR updates cusignal to build against branch cuda-118 of the shared-action-workflow repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

I enabled sm_90 support in builds using CUDA 11.8+.

It also includes some minor file renames.

@github-actions github-actions bot added the conda label Jan 6, 2023
@@ -287,7 +287,7 @@ We have confirmed that cuSignal successfully builds and runs on Windows by using
pip install cupy-cudaXXX
```

Where XXX is the version of the CUDA toolkit you have installed. 11.5, for example is `cupy-cuda115`. See the [CuPy Documentation](https://docs-cupy.chainer.org/en/stable/install.html#install-cupy) for information on getting Windows wheels for other versions of CUDA.
Where XXX is the version of the CUDA toolkit you have installed. 11.5, for example is `cupy-cuda115`. See the [CuPy Documentation](https://docs-cupy.chainer.org/en/stable/install.html#install-cupy) for information on getting wheels for other versions of CUDA.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was searching for content that might need updated regarding CUDA 11.8 and fixed an issue here. I removed the word "Windows" because the wheels needed for WSL are not Windows wheels. They're just normal Linux wheels.

The build script needs to know the gcc and nvcc versions to generate code for the appropriate architectures.
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Base: 71.70% // Head: 71.67% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (8dfcc99) compared to base (eedd6e8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02     #533      +/-   ##
================================================
- Coverage         71.70%   71.67%   -0.03%     
================================================
  Files                51       51              
  Lines              2859     2860       +1     
================================================
  Hits               2050     2050              
- Misses              809      810       +1     
Impacted Files Coverage Δ
python/cusignal/radartools/radartools.py 37.50% <0.00%> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice bdice marked this pull request as ready for review January 10, 2023 23:55
@bdice bdice requested a review from a team as a code owner January 10, 2023 23:55
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2023
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit c0657ef into rapidsai:branch-23.02 Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants