Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -DNVBench_ENABLE_CUPTI=OFF. #1325

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Remove -DNVBench_ENABLE_CUPTI=OFF. #1325

merged 2 commits into from
Feb 26, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 22, 2024

Description

The -DNVBench_ENABLE_CUPTI=OFF flag is no longer needed because of rapidsai/rapids-cmake#504. NVBench CUPTI support is now disabled by default.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner January 22, 2024 17:39
@github-actions github-actions bot added the conda Related to conda and conda configuration label Jan 22, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 22, 2024
@bdice
Copy link
Contributor Author

bdice commented Feb 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit e8be972 into rapidsai:branch-24.04 Feb 26, 2024
59 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @harrism @raydouglass @trxcllnt