-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin gdal to 3.3.x #420
Pin gdal to 3.3.x #420
Conversation
Bump `gdal` from 3.2.x to 3.3.x. Supersedes #347.
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
ok to test |
There are 2 failing tests. Not quite sure what to do with these though 😅 [ FAILED ] PIPRefineTestLarge/0.TestLarge, where TypeParam = float (1063 ms)
[----------] 1 test from PIPRefineTestLarge/0 (1063 ms total)
[----------] 1 test from PIPRefineTestLarge/1, where TypeParam = double
[ RUN ] PIPRefineTestLarge/1.TestLarge
../tests/utilities/column_utilities.cu:68: Failure
Expected equality of these values:
lhs.size()
Which is: 0
rhs.size()
Which is: 885
../tests/utilities/column_utilities.cu:68: Failure
Expected equality of these values:
lhs.size()
Which is: 0
rhs.size()
Which is: 885
../tests/utilities/column_utilities.cu:68: Failure
Expected equality of these values:
lhs.size()
Which is: 0
rhs.size()
Which is: 885
[ FAILED ] PIPRefineTestLarge/1.TestLarge, where TypeParam = double (30 ms)
[----------] 1 test from PIPRefineTestLarge/1 (30 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 2 test suites ran. (1093 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] PIPRefineTestLarge/0.TestLarge, where TypeParam = float
[ FAILED ] PIPRefineTestLarge/1.TestLarge, where TypeParam = double
2 FAILED TESTS |
@thomcom, any thoughts here? |
For some reason I missed this in my github notifications feed, I'll take a look at it this week. Thanks! |
@thomcom any update? Moving to 21.10, please retarget the branch. |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the tests pass? And can we move on with rapidsai/integration#300?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errr, didn't realize this was wip.
rerun tests |
1 similar comment
rerun tests |
@cwharris any chance you can reformat this pr with |
@dillon-cullinan can I get an approve 420? |
@gpucibot merge |
Bump
gdal
from 3.2.x to 3.3.x. Supersedes #347. This is inline with conda-forge's current migration to gdal=3.3.x (see conda-forge/conda-forge-pinning-feedstock#1506 and https://conda-forge.org/status/#gdal33).Update on rapidsai/integration is at rapidsai/integration#300.