Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Sync version update script with CMakeLists and update version in … #438

Merged
merged 2 commits into from
Jul 28, 2021
Merged

FIX Sync version update script with CMakeLists and update version in … #438

merged 2 commits into from
Jul 28, 2021

Conversation

dillon-cullinan
Copy link
Contributor

@dillon-cullinan dillon-cullinan commented Jul 28, 2021 •
edited
Loading

Updates the update-version.sh release script to match the naming convention used in CMakeLists, also updates the value manually since this should've been done on new branch creation.

This should fix the issue where cuspatial will attempt to find cudf 21.08 instead of cudf 21.10.

@dillon-cullinan dillon-cullinan requested review from a team as code owners July 28, 2021 17:20
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library gpuCI Related to Continuous Integration / Automation labels Jul 28, 2021
@dillon-cullinan dillon-cullinan added bug Something isn't working non-breaking Non-breaking change labels Jul 28, 2021
@dillon-cullinan dillon-cullinan requested a review from a team as a code owner July 28, 2021 19:30
@github-actions github-actions bot added the Python Related to Python code label Jul 28, 2021
@dillon-cullinan dillon-cullinan added the 3 - Ready for Review Ready for review by team label Jul 28, 2021
@harrism
Copy link
Member

harrism commented Jul 28, 2021

Thanks @dillon-cullinan

@dillon-cullinan
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0e8e9d1 into rapidsai:branch-21.10 Jul 28, 2021
@vyasr vyasr mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@cwharris cwharris cwharris approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working cmake Related to CMake code or build configuration gpuCI Related to Continuous Integration / Automation libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dillon-cullinan @harrism @cwharris @raydouglass @trxcllnt