Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine device_atomics #561

Merged
merged 15 commits into from
Jun 22, 2022
Merged

Combine device_atomics #561

merged 15 commits into from
Jun 22, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jun 14, 2022

This PR makes device atomics inline and can be included in multiple header files. It also refactors the atomics to reduce duplication.

Closes #547

@isVoid isVoid requested a review from a team as a code owner June 14, 2022 19:17
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Jun 14, 2022
@isVoid isVoid added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 14, 2022
harrism
harrism approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. I think it should move to cuspatial/detail/device_atomics.cuh or cuspatial/detail/utility/device_atomics.cuh.

@isVoid
Copy link
Contributor Author

isVoid commented Jun 15, 2022

rerun tests

@harrism harrism changed the title Combines device_atomics Combine device_atomics Jun 16, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Jun 16, 2022

This is fantastic. I think it should move to cuspatial/detail/device_atomics.cuh or cuspatial/detail/utility/device_atomics.cuh.

Moved to cuspatial/detail/utility/device_atomics.cuh

@isVoid isVoid mentioned this pull request Jun 17, 2022
Merged
harrism
harrism requested changes Jun 19, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid std::min/max in device code.

cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
@isVoid
Merge branch 'branch-22.08' of https://github.com/rapidsai/cuspatial …
c8cb15a 
…into improvement/device_atomics_refactor
@harrism
Copy link
Member

harrism commented Jun 22, 2022

@vyasr if you are satisfied, we can merge this.

vyasr
vyasr approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions for improvement, but assuming that they're implemented I approve!

cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/device_atomics.cuh Show resolved Hide resolved
isVoid and others added 2 commits June 22, 2022 15:27
@isVoid @vyasr
Documentation updates
99a39a3 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@isVoid
make atomicOp inline
25979ae
@isVoid
Copy link
Contributor Author

isVoid commented Jun 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 08b706e into rapidsai:branch-22.08 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@vyasr vyasr vyasr approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine device atomic functions
3 participants
@isVoid @harrism @vyasr