Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linestring_distance Header Only API Returns Past-the-End iterator #670

Merged
merged 6 commits into from
Sep 19, 2022
Merged

linestring_distance Header Only API Returns Past-the-End iterator #670

merged 6 commits into from
Sep 19, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Sep 14, 2022 •
edited by harrism
Loading

Description

This PR updates linestring_distance to return past-the-end iterator to conform to other interfaces. Besides, this PR updates the assumption of offset arrays to be arrow compliant format (N+1 instead of N).

closes #576

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Sep 14, 2022
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change labels Sep 14, 2022
@isVoid isVoid marked this pull request as ready for review September 14, 2022 03:21
@isVoid isVoid requested a review from a team as a code owner September 14, 2022 03:21
@harrism harrism changed the title linestring_distance Header Only API Returns Pass-the-End iterator linestring_distance Header Only API Returns Past-the-End iterator Sep 14, 2022
@harrism harrism requested review from harrism and removed request for zhangjianting September 14, 2022 08:27
@harrism harrism added the 3 - Ready for Review Ready for review by team label Sep 14, 2022
harrism
harrism approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missing @return doc.

cpp/include/cuspatial/experimental/linestring_distance.cuh Show resolved Hide resolved
@isVoid isVoid requested a review from a team as a code owner September 14, 2022 18:18
@github-actions github-actions bot added the Python Related to Python code label Sep 14, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Sep 14, 2022

Thanks for the review. I updated the python tests to address the changes to offset format in this PR.

@isVoid
Copy link
Contributor Author

isVoid commented Sep 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7dc27b6 into rapidsai:branch-22.10 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Pairwise linestring distance should return one past the last written output iterator
3 participants
@isVoid @thomcom @harrism