Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize a GeoDataFrame with dict. #712

Merged
merged 20 commits into from
Oct 3, 2022
Merged

Initialize a GeoDataFrame with dict. #712

merged 20 commits into from
Oct 3, 2022

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Sep 30, 2022 •
edited
Loading

This PR adds support for intializing a GeoDataFrame from a dict of type list or GeoSeries.

Closes #688

@thomcom
Fix style and make memory_usage work properly since cudf will have it…
ae5f3dc 
… tomorrow.
@thomcom
Pass test:
731d73d
@thomcom
Merge branch 'branch-22.10' into fea-add-memory-usage
aac51db
@thomcom
Update geodataframe extensively to better support CUDF internal metho…
7886a79 
…ds on slice and gather.
@thomcom
Merge
145c52d
@thomcom
Create the dict test. Wrestling with trying to use cudf internals.
feb1d38
@thomcom
Merge branch 'fea-add-memory-usage' into fea/initialize-geodataframe-…
97c97d9 
…with-dict
@thomcom
Now initialize geodataframe with dict.
f841d6d
@thomcom
Add a few more tests to ensure I'm delivering what I think.
3b3157f
@thomcom
Minorly update GeoDataFrame docs
290c907
@thomcom
Merge branch 'branch-22.10' into fea/initialize-geodataframe-with-dict
b7dc32e
@thomcom
Don't need that fn.
d4cacd8
@thomcom
Move slice to a better place.
6a36a6e
@thomcom
Remove memory_usage as it has gotten confusing.
2532921
@github-actions github-actions bot added the Python Related to Python code label Sep 30, 2022
@thomcom thomcom added feature request New feature or request 2 - In Progress Currenty a work in progress non-breaking Non-breaking change labels Sep 30, 2022
@thomcom thomcom self-assigned this Sep 30, 2022
@thomcom thomcom mentioned this pull request Sep 30, 2022
Closed
@thomcom thomcom changed the title Fea/initialize geodataframe with dict clean Initialize a GeoDataFrame with dict. Sep 30, 2022
@thomcom thomcom added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Sep 30, 2022
@thomcom thomcom marked this pull request as ready for review September 30, 2022 15:21
@thomcom thomcom requested a review from a team as a code owner September 30, 2022 15:21
@thomcom
Copy link
Contributor Author

thomcom commented Sep 30, 2022

rerun tests

@thomcom
Copy link
Contributor Author

thomcom commented Sep 30, 2022

@harrism do you mind posting an approve?

@thomcom
Copy link
Contributor Author

thomcom commented Sep 30, 2022

@harrism do you mind reviewing?

@thomcom
Copy link
Contributor Author

thomcom commented Oct 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 868e485 into rapidsai:branch-22.10 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees

@thomcom thomcom

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] GeoDataFrame should accept a dictionary of valid columns like GeoPandas and cudf
2 participants
@thomcom @isVoid