Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max version pin for gdal #806

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

ajschmidt8
Copy link
Member

Description

This PR sets a maximum version pin for gdal. Recently, gdal version 3.6.0 was released, which has a different version number for the libgdal shared object (libgdal.so.32 vs. libgdal.so.31).

Setting the max pin here will ensure that we use a consistent libgdal shared object version for building and at runtime.

This should solve the ImportError: libgdal.so.32: cannot open shared object file: No such file or directory errors that have been popping up in recent Jenkins logs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

This PR sets a maximum version pin for `gdal`. Recently, `gdal` version `3.6.0` was released, which has a different version number for the `libgdal` shared object (`libgdal.so.32` vs. `libgdal.so.31`).

Setting the max pin here will ensure that we use a consistent `libgdal` shared object version for building and at runtime.

This should solve the `ImportError: libgdal.so.32: cannot open shared object file: No such file or directory` errors that have been popping up in recent Jenkins logs.
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner November 17, 2022 20:23
@github-actions github-actions bot added the conda Related to conda and conda configuration label Nov 17, 2022
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2022
@thomcom
Copy link
Contributor

thomcom commented Nov 17, 2022

@gpucitbot merge

@harrism
Copy link
Member

harrism commented Nov 17, 2022

Note that there is a interaction with tensorflow and gdal. We had a past PR (can't find, on mobile now) that set / pinned our gdal version in the conda recipe to avoid conflicts with AI packages.

@ajschmidt8
Copy link
Member Author

Note that there is a interaction with tensorflow and gdal. We had a past PR (can't find, on mobile now) that set / pinned our gdal version in the conda recipe to avoid conflicts with AI packages.

Good to know. I think we should be okay here though since we're setting a max pin. The max pin will just exclude the 3.6.0 version of gdal which was released in the last day.

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1e8267b into rapidsai:branch-22.12 Nov 17, 2022
@ajschmidt8
Copy link
Member Author

(there was a typo in Thomson's merge comment)

@ajschmidt8 ajschmidt8 deleted the pin-gdal branch November 17, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants