Refactor calls to data_array_view
#871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Jan 24, 2023
ajschmidt8
added
improvement
Codecov ReportBase: 92.55% // Head: 92.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #871 +/- ##
================================================
+ Coverage 92.55% 92.58% +0.02%
================================================
Files 24 24
Lines 1008 1011 +3
================================================
+ Hits 933 936 +3
Misses 75 75
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
galipremsagar
commented
Jan 24, 2023
ci/build_cpp.sh
Outdated
| @@ -7,10 +7,14 @@ source rapids-env-update | |||
|
|
|||
| export CMAKE_GENERATOR=Ninja | |||
|
|
|||
| LIBCUDF_CHANNEL=$(rapids-get-artifact ci/cudf/pull-request/12587/046025a/cudf_conda_cpp_cuda11_$(arch).tar.gz) | |||
There was a problem hiding this comment.
Temporary changes, will be reverted in few hours
ajschmidt8
approved these changes
Jan 24, 2023
galipremsagar
commented
Jan 24, 2023
ci/build_python.sh
Outdated
| @@ -12,12 +12,18 @@ rapids-print-env | |||
| rapids-logger "Begin py build" | |||
|
|
|||
| CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp) | |||
| PY_VER=${RAPIDS_PY_VERSION//./} | |||
There was a problem hiding this comment.
Temporary changes, will be reverted in few hours
galipremsagar
commented
Jan 24, 2023
ci/test_python.sh
Outdated
| @@ -21,6 +21,9 @@ set -u | |||
| rapids-logger "Downloading artifacts from previous jobs" | |||
| CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp) | |||
| PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python) | |||
| PY_VER=${RAPIDS_PY_VERSION//./} | |||
There was a problem hiding this comment.
Temporary changes, will be reverted in few hours
harrism
approved these changes
Jan 24, 2023
wence-
approved these changes
Jan 25, 2023
isVoid
reviewed
Jan 25, 2023
galipremsagar
commented
Jan 25, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts to the breaking changes being introduced in: rapidsai/cudf#12587
Checklist