Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: Update isort version to 5.12.0 #877

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jan 30, 2023

Description

poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

poetry version 1.5.0 broke installs of isort prior to 5.11.5 (see
PyCQA/isort#2077 and PyCQA/isort#2078), so we need to upgrade.
@codecov-commenter
Copy link

Codecov Report

Base: 92.58% // Head: 92.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6034047) compared to base (f4cf664).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02     #877      +/-   ##
================================================
- Coverage         92.58%   92.57%   -0.01%     
================================================
  Files                24       24              
  Lines              1011     1010       -1     
================================================
- Hits                936      935       -1     
  Misses               75       75              
Impacted Files Coverage Δ
...thon/cuspatial/cuspatial/core/_column/geocolumn.py 94.20% <0.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@harrism
Copy link
Member

harrism commented Jan 31, 2023

Is this needed across the board in RAPIDS repos? Is it crucial for 23.02?

@wence-
Copy link
Contributor Author

wence- commented Jan 31, 2023

Is this needed across the board in RAPIDS repos? Is it crucial for 23.02?

almost everywhere (some repos don't use isort afaict); CI is broken (no code stops working) without this change since it is not possible to set up the pre-commit environment with older isort versions any more (they may backport a fix, but haven't done so yet)

@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Jan 31, 2023
@harrism
Copy link
Member

harrism commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 870b164 into rapidsai:branch-23.02 Jan 31, 2023
@wence- wence- deleted the wence/fix/pre-commit-isort branch January 31, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants