Add valid_count and has_nulls to GeoColumn
#894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcom
added
bug
isVoid
reviewed
Feb 7, 2023
3 tasks
harrism
approved these changes
Feb 7, 2023
Comment on lines
186
to
187
| Null support is implemented in GeoSeries and this is not expected | ||
| to ever return less than the length of the GeoColumn. This is |
There was a problem hiding this comment.
Do we really want to document this expectation in this way? Might cause a user to make assumptions or rely on this expectation.
There was a problem hiding this comment.
I modified the docs, take another look?
isVoid
approved these changes
Feb 10, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstream changes in 23.04 require that columns have
valid_countandhas_nulls. cuSpatial doesn't explicitly support nulls yet, but this PR handles the missing methods so that cudf does not produce messy error messages when one attempts to print a dataframe.Closes #886
As there are no tests for geocolumn and it does not support nulls, tests have not been added for these interface methods at this time.
Checklist