Remove shapefile reader, conda GDAL dependency, move cmake gdal dependency to cpp tests only #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency to cpp tests only
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
cmake
harrism
added
feature request
github-actions
bot
added
cmake
bdice
reviewed
Feb 15, 2023
|
I'm seeing this failure hidden in the C++ tests log
|
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
isVoid
approved these changes
Feb 21, 2023
`gdal` is still required for building `libcuspatial` tests, therefore it is necessary in `dependencies.yaml`
ajschmidt8
approved these changes
Feb 21, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #931.
Removes the shapefile reader (C++ and Python), tests and benchmarks.
Moves the C++ GDAL dependency from libcuspatial's CMakeLists.txt to tests/CMakeLists.txt since one test depends on GDAL.
Checklist