Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --rm and --name to devcontainer run args #89

Merged
merged 3 commits into from
Apr 26, 2024
Merged

add --rm and --name to devcontainer run args #89

merged 3 commits into from
Apr 26, 2024

Conversation

trxcllnt
Copy link
Contributor

  • Remove the devcontainer when the VSCode window closes
  • Adds a descriptive name to the running container: 
    $ docker ps -a
CONTAINER ID   IMAGE         ...  NAMES
0dbb364fe544   vsc-cuvs-...  ...  rapids-cuvs-24.06-cuda12.2-conda

$ docker rm -f rapids-cuvs-24.06-cuda12.2-conda

@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 19, 2024
@trxcllnt trxcllnt mentioned this pull request Apr 19, 2024
Merged
@trxcllnt trxcllnt requested a review from a team as a code owner April 22, 2024 17:18
@github-actions github-actions bot added the ci label Apr 22, 2024
benfred
benfred approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@cjnolet
Copy link
Member

cjnolet commented Apr 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit 32235a4 into branch-24.06 Apr 26, 2024
54 checks passed
difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this pull request Aug 10, 2024
@difyrrwrzd
add --rm and --name to devcontainer run args (#89)
b24076f 
* Remove the devcontainer when the VSCode window closes
* Adds a descriptive name to the running container:
  ```shell
  $ docker ps -a
  CONTAINER ID   IMAGE         ...  NAMES
  0dbb364fe544   vsc-cuvs-...  ...  rapids-cuvs-24.06-cuda12.2-conda
  
  $ docker rm -f rapids-cuvs-24.06-cuda12.2-conda
  ```

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai/cuvs#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@benfred benfred benfred approved these changes

Assignees

@trxcllnt trxcllnt

Labels
ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @cjnolet @benfred @AyodeAwe