Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to scikit-build-core #1287

Merged
merged 5 commits into from Dec 13, 2023
Merged

Switch to scikit-build-core #1287

merged 5 commits into from Dec 13, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 2, 2023 •
edited

Description

Contributes to rapidsai/build-planning#2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 2 - In Progress Currently a work in progress breaking Breaking change improvement Improvement / enhancement to an existing function labels Jun 2, 2023
@vyasr vyasr self-assigned this Jun 2, 2023
@github-actions github-actions bot added CMake conda Python Related to RMM Python API labels Jun 2, 2023
@vyasr vyasr mentioned this pull request Jun 9, 2023
Merged
5 tasks
@github-actions github-actions bot added cpp Pertains to C++ code ci labels Jul 25, 2023
@vyasr vyasr changed the base branch from branch-23.08 to branch-23.10 July 25, 2023 23:53
@github-actions github-actions bot removed the cpp Pertains to C++ code label Jul 29, 2023
@vyasr vyasr added 0 - Blocked Cannot progress due to external reasons and removed 2 - In Progress Currently a work in progress labels Sep 13, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Sep 13, 2023

This change is currently blocked by scikit-build/scikit-build-core#442

@github-actions github-actions bot added the cpp Pertains to C++ code label Dec 1, 2023
@vyasr vyasr changed the base branch from branch-23.10 to branch-24.02 December 1, 2023 23:35
@github-actions github-actions bot removed the cpp Pertains to C++ code label Dec 1, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch 3 times, most recently from 214c69f to d7d190a Compare December 6, 2023 20:56
@github-actions github-actions bot removed the ci label Dec 6, 2023
@vyasr vyasr marked this pull request as ready for review December 12, 2023 23:20
@vyasr vyasr requested review from a team as code owners December 12, 2023 23:20
@vyasr vyasr changed the title Switch from scikit-build to scikit-build-core Switch to scikit-build-core Dec 12, 2023
bdice
bdice reviewed Dec 12, 2023
View reviewed changes
dependencies.yaml Outdated Show resolved Hide resolved
python/CMakeLists.txt Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from bdice December 13, 2023 00:13
@jarmak-nv jarmak-nv mentioned this pull request Dec 13, 2023
Closed
bdice
bdice reviewed Dec 13, 2023
View reviewed changes
conda/recipes/rmm/meta.yaml Outdated Show resolved Hide resolved
python/pyproject.toml Show resolved Hide resolved
python/setup.py Outdated Show resolved Hide resolved
bdice
bdice approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 57ed533 into rapidsai:branch-24.02 Dec 13, 2023
47 checks passed
@vyasr vyasr deleted the feat/scikit_build_core branch December 13, 2023 23:08
@jameslamb jameslamb mentioned this pull request Jan 5, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jan 8, 2024
@jameslamb
remove references to setup.py in docs (#1420)
9265976 
Removes remaining references to `setup.py` in documentation.

This project no longer has a `setup.py` as of its switch to `pyproject.toml` + `scikit-build-core` (see #1287, #1300).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Mark Harris (https://github.com/harrism)

URL: #1420
@vyasr vyasr mentioned this pull request May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard

Assignees

@vyasr vyasr

Labels
0 - Blocked Cannot progress due to external reasons breaking Breaking change CMake conda improvement Improvement / enhancement to an existing function Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vyasr @robertmaynard @bdice @ajschmidt8