Fix ordering / heading levels in README.md and python example in guide.md #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
doc
wence-
requested changes
Apr 2, 2024
python/docs/guide.md
Outdated
| ```python | ||
| from rmm.allocators.torch import rmm_torch_allocator | ||
| import torch | ||
| ```python |
There was a problem hiding this comment.
question: Why the indentation of this whole block by a single character? I think it is unnecessary.
wence-
approved these changes
Apr 10, 2024
|
/merge |
|
I noticed while reading through that we still say that one must manually ensure that the correct device is active when the destructor for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor fix to reorder some of the C++ docs in README.md and fix heading levels. It also adds prompt characters to the pytorch allocator example in the Python guide.md to be consistent with other examples in the doc.
Checklist