Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated supports_streams and get_mem_info methods. #1519

Conversation

harrism
Copy link
Member

@harrism harrism commented Apr 4, 2024

Description

Fixes #1388
Fixes #1389
Fixes #1428
Fixes #1434

Removes the previously deprecated functions

  • rmm::mr::device_memory_resource::supports_streams()
  • rmm::mr::device_memory_resource::supports_get_mem_info()
  • rmm::mr::device_memory_resource::get_mem_info()

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner April 4, 2024 06:25
@harrism harrism requested review from miscco and jrhemstad April 4, 2024 06:25
@harrism harrism added feature request New feature or request breaking Breaking change cpp Pertains to C++ code labels Apr 4, 2024
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@harrism
Copy link
Member Author

harrism commented Apr 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit 48820cb into rapidsai:branch-24.06 Apr 5, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cpp Pertains to C++ code feature request New feature or request
Projects
Status: Done
4 participants