Add available_device_memory to fetch free amount of memory on a GPU
#1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
non-breaking
3 tasks
wence-
requested changes
May 22, 2024
| @@ -1188,3 +1188,10 @@ def get_log_filenames(): | |||
| else None | |||
| for i, each_mr in _per_device_mrs.items() | |||
| } | |||
|
|
|||
|
|
|||
| def get_free_device_memory(percent): | |||
There was a problem hiding this comment.
nit: let's make this parameter self-documenting with:
def get_free_device_memory(*, percent: int):
WDYT?
bdice
reviewed
May 28, 2024
galipremsagar
commented
May 28, 2024
bdice
reviewed
May 28, 2024
bdice
reviewed
May 28, 2024
harrism
changed the title
get_free_device_memory to fetch free amount of memory on a GPUavailable_device_memory to fetch free amount of memory on a GPU
bdice
approved these changes
May 30, 2024
|
|
||
| def available_device_memory(): | ||
| """ | ||
| Returns a tuple of free and total device memory memory. |
There was a problem hiding this comment.
I wish this was in a Returns block that follows numpy docstring style but it doesn't seem like RMM uses full docstrings...
There was a problem hiding this comment.
RMM Python is immature in a lot of ways. No time like the present...
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
wence-
approved these changes
Jun 4, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
get_free_device_memorythat returns free GPU memory necessary for rapidsai/cudf#15628Checklist