Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect href in README.md [skip-ci] #804

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix incorrect href in README.md [skip-ci] #804

merged 1 commit into from
Jun 15, 2021

Conversation

benchislett
Copy link
Contributor

Github's anchor links don't include +s. The ref is therefore not matching the desired section, and nothing happens when the link is clicked. To verify, click the anchor icon in the Using RMM in C++ section and check your browser's url bar.

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@harrism harrism added doc Documentation non-breaking Non-breaking change labels Jun 15, 2021
@harrism
Copy link
Member

harrism commented Jun 15, 2021

@gpucibot merge

@harrism harrism changed the title Fix incorrect href in README.md Fix incorrect href in README.md [skip-ci] Jun 15, 2021
@harrism
Copy link
Member

harrism commented Jun 15, 2021

ok to test

@harrism
Copy link
Member

harrism commented Jun 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 91491aa into rapidsai:branch-21.08 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants