Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython extension for rmm::cuda_stream_pool #818

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Cython extension for rmm::cuda_stream_pool #818

merged 3 commits into from
Jul 19, 2021

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala requested a review from a team as a code owner July 8, 2021 19:34
@divyegala divyegala marked this pull request as draft July 8, 2021 19:34
@github-actions github-actions bot added the Python Related to RMM Python API label Jul 8, 2021
@jakirkham jakirkham mentioned this pull request Jul 8, 2021
Closed
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 8, 2021
@github-actions github-actions bot added the cpp Pertains to C++ code label Jul 12, 2021
@divyegala
Copy link
Member Author

@jakirkham could I get a review from you for the cython side? Also @jrhemstad, I have removed explict from the conversion operator between rmm::cuda_stream_view and cudaStream_t

@divyegala divyegala marked this pull request as ready for review July 14, 2021 20:59
@divyegala divyegala requested a review from a team as a code owner July 14, 2021 20:59
@divyegala divyegala mentioned this pull request Jul 14, 2021
Merged
harrism
harrism requested changes Jul 14, 2021
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the brief.

include/rmm/cuda_stream_view.hpp Outdated Show resolved Hide resolved
@divyegala @harrism
Update brief
b9c776c 
Co-authored-by: Mark Harris <mharris@nvidia.com>
@divyegala divyegala requested a review from harrism July 15, 2021 16:03
@harrism
Copy link
Member

harrism commented Jul 19, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 09a673e into rapidsai:branch-21.08 Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina shwina approved these changes

@harrism harrism harrism approved these changes

@rongou rongou Awaiting requested review from rongou

@codereport codereport Awaiting requested review from codereport

Assignees
No one assigned
Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyegala @harrism @shwina @galipremsagar @jakirkham