Mark optional CUDA runtime functions as weak symbols #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
rongou
approved these changes
Oct 19, 2021
harrism
reviewed
Oct 19, 2021
Will make it easier to support other compilers
cudaDevAttrMemoryPoolsSupported only checks that the driver supports cudaMemPools, not that the runtime does as well.
JohnZed
reviewed
Oct 20, 2021
| #if CUDART_VERSION >= 11020 // 11.2 introduced cudaMallocAsync | ||
| #define RMM_CUDA_MALLOC_ASYNC_SUPPORT | ||
|
|
||
| #ifndef RMM_WEAK_ATTRIBUTE |
There was a problem hiding this comment.
Maybe a comment is worth it here to explain what's going on?
|
|
||
| // We first need to check if the runtime version supports cudaMemPool | ||
| // before checking that the driver does. | ||
| int version = 0; |
There was a problem hiding this comment.
My personal style would be to break out these checks (driver + runtime) into a helper function like cuda_malloc_async_available() to simplify the constructor and encapsulate these annoying details. However, it is only used one place, so I can certainly live with this as well.
There was a problem hiding this comment.
It's a good idea considering #889 may cause duplication of the checks.
|
Closing this PR as the weak symbol approach is non-viable for all supported platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.