-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scikit-build for the build process #976
Conversation
…ing from the source directory.
CC @kkraus14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise this looks amazing!
rerun tests |
Ah good catch, I had noticed that earlier but forgot to address it. I think we'll need to bring this up with the skbuild team, I think skbuild automatically identifies subpackage by |
@ajschmidt8 and I just met and went through installing these conda packages into a fresh environment. Everything looks good, the package is well-formed and Python tests pass so at this point I think I'm comfortable proceeding. I think it's very unlikely that we will run into conda package issues at this point, and if someone finds bugs trying to build from source due to unexpected system configuration I expect them to be a small enough portion of the user base that we can work to resolve those issues if and when they arise. |
@robertmaynard @rapidsai/rmm-python-codeowners please take a final look at this PR, we can merge once you've approved. |
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
@gpucibot merge |
This PR replaces a lot of the setuptools logic with using scikit-build, which allows us to leverage the existing CMake configuration for the C++ components of RMM to build the Python package using standard pip- and setup.py-based installs. Replaces #637.