Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for virtualenv compatability #16

Closed
wants to merge 2 commits into from
Closed

Conversation

mrbell
Copy link

@mrbell mrbell commented Aug 4, 2016

Fix for #15 using pip to fetch package info rather than pkg_resources.

I was also getting an exception using the -w flag due to __version__ being unreferenced, so I added import __init__ to make the version accessible within watermark.py.

Michael Bell added 2 commits August 3, 2016 21:58
Fixes rasbt#15 using pip to get package info gets correct
package versions when using the system jupyter notebook or ipython console from
within a virtualenv environment.

Also added an import from __init__.py to make __version__ accessible
from within watermark.py
@mrbell
Copy link
Author

mrbell commented Aug 4, 2016

A new solution was proposed in #15 that does not require the pip dependency. I'll submit a new PR with that solution and including a python 2 & 3 compatible fix for the -w flag.

@mrbell mrbell closed this Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant