Skip to content

Update LCD display instructions #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 17, 2019
Merged

Update LCD display instructions #1355

merged 10 commits into from
Dec 17, 2019

Conversation

JamesH65
Copy link
Contributor

@JamesH65 JamesH65 commented Dec 4, 2019

Needed updating for the FKMS change on Pi4.

Needed updating for the FKMS change on Pi4.
Copy link
Contributor

@6by9 6by9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.
I could insert the rotate=X line into the command line if it was viewed useful. Seeing as X ignores it, I'm not sure it is.

@lurch
Copy link
Contributor

lurch commented Dec 4, 2019

Just noticed that this page (outside of the text being edited in this PR) mentions both display_lcd_rotate and display_hdmi_rotate - is one of them wrong?

@lurch
Copy link
Contributor

lurch commented Dec 4, 2019

Does the FKMS mode support the "flip" option that the Legacy mode supports?

@lurch
Copy link
Contributor

lurch commented Dec 4, 2019

"The DSI display is designed to work with Raspberry Pi models 2, 3 and 4 that have mounting holes in a HAT footprint. Model 1 A/B boards are supported, but require additional mounting hardware to fit the HAT-dimensioned stand-offs on the display PCB."

Minor nitpick - which category do the Model 1 A+ and B+ fall into?

@6by9
Copy link
Contributor

6by9 commented Dec 4, 2019

Does the FKMS mode support the "flip" option that the Legacy mode supports?

Yes, you can add reflect_x and reflect_y as well as rotate=N to the video= entry in cmdline.txt

@JamesH65
Copy link
Contributor Author

JamesH65 commented Dec 6, 2019

Does the FKMS mode support the "flip" option that the Legacy mode supports?

Yes, you can add reflect_x and reflect_y as well as rotate=N to the video= entry in cmdline.txt

Does this need to be added to the PR?

@JamesH65
Copy link
Contributor Author

Unless people want the reflect items added, I'm inclined to merge this. Any objections or improvements?

@ghost
Copy link

ghost commented Dec 12, 2019

"The DSI display is designed to work with Raspberry Pi models 2, 3 and 4 that have mounting holes in a HAT footprint. Model 1 A/B boards are supported, but require additional mounting hardware to fit the HAT-dimensioned stand-offs on the display PCB."

Minor nitpick - which category do the Model 1 A+ and B+ fall into?

The Pi 1 model A+ and B+ are the same shape as the later boards, and have the mounting holes in the same place. Perhaps this sentence should instead read:

"The DSI display is designed to work on all models of Raspberry Pi, however early models (The Raspberry Pi 1 model A and B) will require additional mounting hardware to fit the HAT-dimensioned stand-offs on the display PCB."

@JamesH65
Copy link
Contributor Author

Have made a change similar to that suggested by @andrum99 , any other comment prior to merging?

@JamesH65 JamesH65 merged commit 2c17566 into master Dec 17, 2019
@JamesH65 JamesH65 deleted the JamesH65-patch-LCD-update branch January 2, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants