Skip to content

Conversation

cinghioGithub
Copy link
Contributor

Linux kernel contribution does not happen on Github, but on mailing list. Update this information in the Linux kernel contribution guideline.

Linux kernel contribution does not happen on Github, but on mailing list.
Update this information in the Linux kernel contribution guideline.

Signed-off-by: Enrico Bravi <enrico.bravi@polito.it>
@nathan-contino
Copy link
Contributor

@pelwell I'm inclined to pull this into the docs because it's definitely more correct than what's there right now. Is there anything else we should emphasize in this process, or does this pretty much cover it?

@pelwell
Copy link
Contributor

pelwell commented Jul 29, 2024

That's fine with me, once you've fixed the style issues (and I would drop the "the" from "Please follow the https://www.kernel.org/doc/...").

@cinghioGithub
Copy link
Contributor Author

@pelwell I'm inclined to pull this into the docs because it's definitely more correct than what's there right now. Is there anything else we should emphasize in this process, or does this pretty much cover it?

I think that's pretty much it. I'll add a reference to the Linux kernel coding style guide. Other than that I think it's complete enough.

- Fixed style problems
- Add Linux kernel coding style reference

Signed-off-by: Enrico Bravi <enrico.bravi@polito.it>
@cinghioGithub cinghioGithub requested a review from lurch July 31, 2024 09:43
@cinghioGithub
Copy link
Contributor Author

@pelwell @lurch @nathan-contino do I need to fix something else?

@pelwell
Copy link
Contributor

pelwell commented Aug 5, 2024

I think you just need to be patient during the holiday season.

@lurch lurch removed their request for review August 5, 2024 12:24
Copy link
Contributor

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay! This is highly appreciated.

@nathan-contino nathan-contino merged commit f9e5722 into raspberrypi:develop Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants