Skip to content

Update v2 max framerate according this github commit avaliable with M… #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Conversation

Hermann-SW
Copy link
Contributor

…arch 2018 Raspbian Stretch:

Hexxeh/rpi-firmware@f6f7e04
"firmware: imx219: Increase max frame rate at 640x480 to 200fps"

…arch 2018 Raspbian Stretch:

Hexxeh/rpi-firmware@f6f7e04
"firmware: imx219: Increase max frame rate at 640x480 to 200fps"
@JamesH65
Copy link
Contributor

JamesH65 commented Jul 3, 2018

@6by9 Is this a valid change - i.e. do we get this using default software?

@JamesH65 JamesH65 added the waiting for comment Awaiting a response label Jul 3, 2018
@6by9
Copy link
Contributor

6by9 commented Jul 3, 2018

It needs a comment to say that >120fps is only achievable with -ex off (and possibly -awb off).
The sensor can frame that fast, but the tuner doesn't keep up.
AE certainly limits things. AWB is in a separate thread and therefore shouldn't block things, but I couldn't say for certain that it won't cause issues without trying it.

@JamesH65
Copy link
Contributor

JamesH65 commented Jul 3, 2018

I can put the caveats on a superscripted footnote i.e.

"For frame rates over 120fps, it is necessary to turn off AEC using -ex off and AWB using -awb off. This will help maintain higher frame rates but result in lower quality images. "

I'll knock up a PR for review.

@JamesH65
Copy link
Contributor

JamesH65 commented Jul 3, 2018

OK, have updated the original PR, any comments?

|7|640x480|4:3|40-90fps|Partial|2x2|
|7|640x480|4:3|40-200fps<sup>1</sup>|Partial|2x2|

<sup>1</sup>For frame rates over 120fps, it is necessary to turn off AEC using `-ex off` and AWB using `-awb off`. This will help maintain higher frame rates but result in lower quality images. We do not guarantee framerates over 120fps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checked - AWB doesn't have an effect.

"For frame rates over 120fps, it is necessary to turn off automative exposure and gain control off using -ex off. Doing so should achieve the higher frame rates, but exposure time and gains will be set to fixed values as supplied by the user."

@6by9
Copy link
Contributor

6by9 commented Jul 3, 2018

Ship it.

@JamesH65 JamesH65 merged commit 206537e into raspberrypi:master Jul 3, 2018
@Hermann-SW
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for comment Awaiting a response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants