5.15 KMS fixes #4821
Merged
5.15 KMS fixes #4821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popcornmix
reviewed
Jan 11, 2022
popcornmix
reviewed
Jan 11, 2022
|
LGTM (apart from two comments). |
popcornmix
force-pushed
the
rpi-5.15.y
branch
2 times, most recently
from
6f90877 to
00de1d0
Compare
The bits in both DISPCTRL and DISPSTAT have moved between hvs4 and hvs5, and the driver wasn't taking that into account. This lead to VSTART being enabled on channel 2, which nothing then acknowledged and lead to the parent interrupt being disabled. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Move from only supporting the default of pre-multiplied alpha to supporting user specified blend mode using the standardised property. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
Comments fixed and rebased. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jan 17, 2022
kernel: 5.15 KMS fixes See: raspberrypi/linux#4821 firmware: Update to latest master
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jan 17, 2022
kernel: 5.15 KMS fixes See: raspberrypi/linux#4821 firmware: Update to latest master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up interrupt handling for HVS5. Bits have moved in DISPSTAT and DISPCTRL, and the driver wasn't taking it into account.
This effectively extends what popcornmix had done with 3474e57.
I was seeing VSTART2 occurring and not being acknowledged when 3 displays were active. This resulted in the interrupt being disabled, which then meant no further dlist updates.
Adds a blend_mode property to allow for non-pre-multiplied alpha (or ignore alpha).