sh1106.py: Fix the pin numbers in the example code. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pins numbers of the example code did not match the RP2040. This is fixed now.
|
LGTM. @lurch? |
|
I don't have a SH1106 with which to test, but yeah this LGTM 👍 |
|
I tested that sample code using a SH1106 with both I2C and SPI settings. |
|
Merged. It'll get pulled into the PDF documentation on the next public release. |
|
(it's only the README.adoc that gets pulled into the PDF documentation, which this PR hasn't modified 😉 ) |
|
The code also gets pulled into the PDF. You should remember that, you wrote the scripting. 😄
|
|
Oh! I'd forgotten that 😆 🤣 🍳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pins numbers of the example code in sh1106.py did not match the
RP2040 pins. Instead, pin numbers suitable for ESP8266 were listed.