Skip to content

I2c slave #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2023
Merged

I2c slave #1205

merged 4 commits into from
Feb 7, 2023

Conversation

kilograham
Copy link
Contributor

@kilograham kilograham commented Jan 27, 2023 •
edited
Loading

@kilograham
Copy link
Contributor Author

cc @vmilea

@peterharperuk peterharperuk self-requested a review February 2, 2023 16:41
peterharperuk
peterharperuk previously approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. But looks ok to me

@peterharperuk peterharperuk mentioned this pull request Feb 2, 2023
Merged
@peterharperuk
Copy link
Contributor

raspberrypi/pico-examples#320

@kilograham kilograham added this to the 1.5.0 milestone Feb 5, 2023
andygpz11
andygpz11 previously approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@andygpz11 andygpz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works with the 'i2c slave example' from #320, just as the original did.

andygpz11
andygpz11 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@andygpz11 andygpz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd missed that but all good now.

@kilograham kilograham merged commit 18b97fc into develop Feb 7, 2023
@kilograham kilograham deleted the i2c_slave branch February 7, 2023 13:47
@andygpz11 andygpz11 mentioned this pull request Feb 8, 2023
Merged
@lurch lurch mentioned this pull request Sep 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygpz11 andygpz11 andygpz11 approved these changes

@peterharperuk peterharperuk peterharperuk left review comments

Assignees

@andygpz11 andygpz11

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kilograham @peterharperuk @andygpz11