pico_stdio improvements #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kilograham
commented
Oct 7, 2021
kilograham
commented
- add stdio_usb_connected() method
- add PICO_STDIO_USB_CONNECT_WAIT_TIMEOUT_MS to allow waiting for CDC connection during init
- add puts_raw and putchar_raw to skip any CR/LF translation
add PICO_STDIO_USB_CONNECT_WAIT_TIMEOUT_MS to allow waiting for CDC connection during init add puts_raw and putchar_raw to skip any CR/LF translation
This was
linked to
issues
Oct 7, 2021
Suggestion: Add a putchar_raw() or similar function for sending bytes over Serial without CR/LF
#224
Closed
lurch
reviewed
Oct 7, 2021
lurch
reviewed
Oct 7, 2021
lurch
reviewed
Oct 7, 2021
lurch
reviewed
Oct 7, 2021
lurch
reviewed
Oct 7, 2021
| * | ||
| * \return true if stdio is connected over CDC | ||
| */ | ||
| bool stdio_usb_connected(void); |
There was a problem hiding this comment.
I guess a common usage-idiom (for example-code that wants to be switchable between UART and USB-CDC using just the CMakeLists.txt mechanism) would be to wrap this inside a #if LIB_PICO_STDIO_USB ? Would that code need to also explicitly include stdio_usb.h inside a #if LIB_PICO_STDIO_USB too?
Or have I grabbed the totally wrong end of the stick? 🙃
There was a problem hiding this comment.
yes you would do exact all that... however the other #define stuff avoids you having to mess with stuff. I did not want to try to shoe-horn connection waiting into the abstraction for stdio drivers atm especially since the UART one is not capable of waiting even though you could detect a UART connection with more pins
lurch
reviewed
Oct 7, 2021
liamfraser
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.