Add DatanoiseTV DSP Board. #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesH65
reviewed
Jun 15, 2022
| @@ -0,0 +1,71 @@ | |||
| /* | |||
| * Copyright (c) 2022 Raspberry Pi (Trading) Ltd. | |||
| * | |||
There was a problem hiding this comment.
I suspect this copyright is wrong.
There was a problem hiding this comment.
I have copied it from the other board files, which also didn't seem to change the copyright.
|
Is this product actually for sale at this point? |
It is available on GitHub as an open source project, with BOM and assembly files for JLCPCB assembly. |
lurch
reviewed
Jun 15, 2022
Comment on lines
24
to
32
| #ifndef PICO_DEFAULT_UART | ||
| #define PICO_DEFAULT_UART 0 | ||
| #endif | ||
| #ifndef PICO_DEFAULT_UART_TX_PIN | ||
| #define PICO_DEFAULT_UART_TX_PIN 0 | ||
| #endif | ||
| #ifndef PICO_DEFAULT_UART_RX_PIN | ||
| #define PICO_DEFAULT_UART_RX_PIN 1 | ||
| #endif |
There was a problem hiding this comment.
These are the same as the values in pico.h, which you're #include-ing at the bottom of this file anyway?
There was a problem hiding this comment.
Correct, you can delete these.
kilograham
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the DatanoiseTV RP2040 Audio DSP board.
https://twitter.com/DatanoiseTV/status/1536705299964481540