fix: fail early if there is no tmp dir specified #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still working on tests for this... |
raszi
changed the title
|
@raszi thank you for the review. I will try to address these issues ASAP. |
silkentrance
force-pushed
the
gh-176
branch
3 times, most recently
from
b0ad81a
to
71b00bf
Compare
Missing tests have been added. |
…ependency that somehow got lost
|
@raszi tests have been added. |
|
Merging now as all change requests have been met. |
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.
This will cause
_generateTmpNameto fail early if bothopts.dirandtmpDirare undefined.