-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump PHP7 version and PHPUnit #773
Conversation
@cboden answering #774 (comment) here as it's related to this PR. It was impossible to write tests for it properly when code relied on ini*()_ calls. Tests throw |
I see. In that case I think it would be best to alter the |
What about now |
Tests are failing 😬 |
Run them locally and passed. Dunno why travis installs symfony/routing v5 when constrain is Rebasing on current master and fixing. |
Its very useful. Thanks! |
@cboden hi, do you have any further comments? |
Hey @simPod. Thank you for your work on this and my apologies for my delayed response. We think we're going to use your PR as a base for v0.5. One small change request: could you move the OptionsHandler code to our Session namespace please? Since it's not used outside Sessions and it's a requirement for Sessions I don't think we need it more widely scoped. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for PR @simPod .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple tiny comments. Thank you for all your hard work @simPod
Let's bump PHP to secure supported version. So we can make further improvements to the lib without pain. Eg. see #774. There is v0.4 released with PHP5 support so should be no deal to consumers.
I tried to keep changes at minimum but eg. it's impossible to decently test code with ini_get/ini_set so I had to do small modifications (see Changelog).