Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add procedures to mitigate installation errors on update #388

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Add procedures to mitigate installation errors on update #388

merged 1 commit into from
Jun 1, 2024

Conversation

Akkarinage
Copy link
Member

@Akkarinage Akkarinage commented Mar 16, 2024 •
edited
Loading

Fixes #168, Fixes #380

Changes proposed in this Pull Request:

  • Added procedures which enables the query to silently fail if the column already exists instead of throwing an error, halting the process.

Please test!

@Akkarinage Akkarinage self-assigned this Mar 16, 2024
@Akkarinage Akkarinage added the Testing Required This PR requires testing and feedback before merging label Mar 18, 2024
@Akkarinage
Copy link
Member Author

Has anybody tested these yet?

@reunite-ro
Copy link

Ive tried reinstalled without deleting the old database, seems okay, not throwing the data exist issue.

@Akkarinage Akkarinage merged commit d6d9b73 into rathena:master Jun 1, 2024
7 checks passed
@Akkarinage Akkarinage deleted the hotfix/issue168 branch June 1, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Akkarinage Akkarinage

Labels
Component: Installation Testing Required This PR requires testing and feedback before merging
Projects
None yet
Milestone
No milestone
2 participants
@Akkarinage @reunite-ro