Refactored Instances to utilize C++ features #3163

aleos89 · 2018-05-27T15:29:44Z

Addressed Issue(s): Memory leak detected at ERS #3087, instance script command update #3095
Server Mode: Pre-renewal and Renewal
Description of Pull Request:
- Converted database file to YAML.
- Converted static array to unordered_map which frees up 14400+ bytes of pre-allocated memory that may never be fully used.
- Got rid of all DBMap/ERS features.

TODO:

Convert instance_wait to dynamic array.

* Fixes #3087 and fixes #3095. * Converted database file to YAML. * Converted static array to unordered_map which frees up 14400+ bytes of pre-allocated memory that may never be fully used. * Got rid of all DBMap/ERS features.

* Resolved a compile error. * Adjusted Windows build to properly move the import file over. * Removed some left overs.

@Lemongrass3110

* Removed references. * Adjusted the instance name search to start to an iterator. * Renamed Maps field to AdditionalMaps. Thanks to @Lemongrass3110 and @secret!

* Final compile error. * Added database file adjustments.

* Fixed a few instances of string to c_str conversions.

* Added new instances.

* Allows for quick and dynamic modification. * Reduces memory usage of statically allocated array.

# Conflicts: # src/map/instance.cpp # src/map/instance.hpp

db/import-tmpl/instance_db.yml

@Atemo

* Instance names should also be unique as they have their own lookup. Thanks to @Atemo!

* Corrected a compile error. * Cleaned up instance enter location parsing.

ghost · 2018-07-01T07:13:49Z

Does this include the fix for #3150 ?

aleos89 · 2018-07-02T00:18:42Z

No, but we have some code in place for it’s implementation after this gets pushed to master. Wanted to keep a feature addition separate from a refactor.

# Conflicts: # .travis.yml

mjonrest · 2018-07-09T07:34:14Z

instance.cpp: In function ‘void instance_addnpc(std::shared_ptr<s_instance_data>)’:
instance.cpp:368:28: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
for(i = 0; i < idata->map.size(); i++)
^~~~
instance.cpp:369:59: error: request for member ‘src_m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map’ (maybe you meant to use ‘->’ ?)
map_foreachinallarea(instance_addnpc_sub, idata->map[i].src_m, 0, 0, map[idata->map[i].src_m].xs, map[idata->map[i].src_m].ys, BL_NPC, idata->map[i].m);
^~~~~
instance.cpp:369:90: error: request for member ‘src_m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
a(instance_addnpc_sub, idata->map[i].src_m, 0, 0, map[idata->map[i].src_m].xs, map[idata->map[i].src_m].ys, BL_NPC, idata->map[i].m);
^~~~~
instance.cpp:369:119: error: request for member ‘src_m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
map[i].src_m, 0, 0, map[idata->map[i].src_m].xs, map[idata->map[i].src_m].ys, BL_NPC, idata->map[i].m);
^~~~~
instance.cpp:369:152: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)) ’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
idata->map[i].src_m].xs, map[idata->map[i].src_m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:372:28: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
for(i = 0; i < idata->map.size(); i++)
^~~~
instance.cpp:373:56: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map’ (maybe you meant to use ‘->’ ?)
map_foreachinallarea(instance_npcinit, idata->map[i].m, 0, 0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:373:83: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
nallarea(instance_npcinit, idata->map[i].m, 0, 0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:373:108: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)) ’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
, idata->map[i].m, 0, 0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:373:137: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)) ’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp: In function ‘int instance_addmap(uint16)’:
instance.cpp:515:13: error: request for member ‘push_back’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
idata->map.push_back(entry);
^~~~~~~~~
instance.cpp:525:15: error: request for member ‘push_back’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
idata->map.push_back(entry);
^~~~~~~~~
instance.cpp:555:20: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
return idata->map.size();
^~~~
instance.cpp: In function ‘int16 instance_mapid(int16, uint16)’:
instance.cpp:583:36: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
for (uint16 i = 0; i < idata->map.size(); i++) {
^~~~
instance.cpp:584:21: error: request for member ‘src_m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
if (idata->map[i].src_m == m) {
^~~~~
instance.cpp: In function ‘bool instance_destroy(uint16)’:
instance.cpp:670:29: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
for(i = 0; i < idata->map.size(); i++)
^~~~
instance.cpp:671:60: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map’ (maybe you meant to use ‘->’ ?)
map_foreachinallarea(instance_npcdestroy, idata->map[i].m, 0, 0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:671:87: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
larea(instance_npcdestroy, idata->map[i].m, 0, 0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:671:112: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)) ’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
, idata->map[i].m, 0, 0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:671:141: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)) ’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
0, map[idata->map[i].m].xs, map[idata->map[i].m].ys, BL_NPC, idata->map[i].m);
^
instance.cpp:672:29: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
for(i = 0; i < idata->map.size(); i++)
^~~~
instance.cpp:673:37: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map’ (maybe you meant to use ‘->’ ?)
map_delinstancemap(idata->map[i].m);
^
instance.cpp:674:14: error: request for member ‘clear’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
idata->map.clear();
^~~~~
instance.cpp: In function ‘bool instance_delusers(uint16)’:
instance.cpp:893:32: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
for(int i = 0; i < idata->map.size() && idata->map[i].m; i++)
^~~~
instance.cpp:893:56: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
for(int i = 0; i < idata->map.size() && idata->map[i].m; i++)
^
instance.cpp:894:34: error: request for member ‘m’ in ‘(((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map + ((sizetype)(((long unsigned int)i) * 8)))’, which is of pointer type ‘s_instance_map*’ (maybe you meant to use ‘->’ ?)
users += max(map[idata->map[i].m].users,0);
^
instance.cpp: In function ‘void do_reload_instance()’:
instance.cpp:1147:19: error: request for member ‘size’ in ‘((std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>*)(& idata))->std::__shared_ptr_access<s_instance_data, (__gnu_cxx::_Lock_policy)2, false, false>::operator->()->s_instance_data::map’, which is of non-class type ‘s_instance_map**’
if (!idata->map.size())

i found this error.. can someone help me with this

aleos89 · 2018-07-10T21:54:14Z

Looks like you have a bad merge. I cannot reproduce this.

mjonrest · 2018-07-11T02:50:11Z

@aleos89 i have follow all steps and commits and this happen.. i use latest master from rathena..

aleos89 · 2018-07-12T01:10:05Z

I'd check your s_instance_data struct and make sure your define of map is a vector and not the previous ERS format.

mjonrest · 2018-07-12T01:26:49Z

@Do you need my src folder?? i can share it to you

@ecdarreola

* Follow up to 0476686. Thanks to @ecdarreola!

lgtm-com · 2020-03-25T13:38:49Z

This pull request fixes 2 alerts when merging cfaefa2 into 24ecebc - view on LGTM.com

fixed alerts:

1 for Comparison result is always the same
1 for Comparison of narrow type with wide type in loop condition

ecdarreola · 2020-03-25T13:48:22Z

Timer is now showing properly. Image below.

Test 1:

Test 2:

Thank you. Everything is working great!

CairoLee · 2020-03-25T14:58:58Z

@CairoLee is there an issue I'm missing or you're bumping so it gets merged to master?

Sorry for making you misunderstand, Sir. I did not encounter any issues. I just so looking forward to this pull request. but i seem there has been no activity in the last month, so I "remind" you to pay attention to it. ;D

@Atemo

* Adds a check to make sure Instance names are unique. Thanks to @Atemo!

lgtm-com · 2020-03-30T19:45:01Z

This pull request fixes 2 alerts when merging df651cb into 2f326bf - view on LGTM.com

fixed alerts:

1 for Comparison result is always the same
1 for Comparison of narrow type with wide type in loop condition

* Converts the Additional Maps format to support importing. * Fixes an invalid map name check.

lgtm-com · 2020-03-31T00:57:20Z

This pull request fixes 2 alerts when merging e4f1d72 into 2f326bf - view on LGTM.com

fixed alerts:

1 for Comparison result is always the same
1 for Comparison of narrow type with wide type in loop condition

lgtm-com · 2020-04-01T16:09:17Z

This pull request fixes 2 alerts when merging a9302e3 into ad820c1 - view on LGTM.com

fixed alerts:

1 for Comparison result is always the same
1 for Comparison of narrow type with wide type in loop condition

* Adjusts some checks for the change from unsigned short to int of instance_id.

lgtm-com · 2020-04-07T13:24:56Z

This pull request fixes 2 alerts when merging 4e21219 into 3424928 - view on LGTM.com

fixed alerts:

1 for Comparison result is always the same
1 for Comparison of narrow type with wide type in loop condition

@Atemo

* Adds a map name length check when creating unique IDs to not exceed 999. Thanks to @Atemo!

lgtm-com · 2020-04-07T17:54:20Z

This pull request fixes 2 alerts when merging 4aec65c into 3424928 - view on LGTM.com

fixed alerts:

1 for Comparison result is always the same
1 for Comparison of narrow type with wide type in loop condition

Chywoner · 2020-04-13T01:57:16Z

How to resolve this error?

Lemongrass3110 · 2020-04-13T12:00:02Z

How to resolve this error?

Update correctly. You are either missing the include or the using directive.

SeravySensei · 2020-05-06T16:46:53Z

How to resolve this error?

Update correctly. You are either missing the include or the using directive.

Having the same problem. If I right click the "util" and select "go to definition", it does find the declaration "namespace util" in utilities.hpp which seems to be listed as an include but I can't compile it anyway.
... changing to "rathena::util::.." fixed the errors. I hope that was the correct solution.

aleos89 · 2020-05-06T17:01:07Z

You're forgetting the using namespace rathena; definition at the to near the includes.

admkakaroto · 2020-06-08T14:02:33Z

@aleos89 #3150
Will this old report still be worked on? in it you said it would be in this PR, but ended up being forgotten.

Atemo · 2020-06-08T15:05:27Z

Maybe Aleos meant #3753 ?

aleos89 · 2020-06-08T19:44:46Z

It's not forgotten about. I've just been working on other tasks.

admkakaroto · 2020-06-09T13:34:37Z

Oh, fine then, thanks!

aleos89 and others added 6 commits May 27, 2018 11:28

Refactored Instances to utilize C++ features

d00e12a

* Fixes #3087 and fixes #3095. * Converted database file to YAML. * Converted static array to unordered_map which frees up 14400+ bytes of pre-allocated memory that may never be fully used. * Got rid of all DBMap/ERS features.

Abort travis scripts on build error

a3397d9

Follow up to d00e12a

5a48451

* Resolved a compile error. * Adjusted Windows build to properly move the import file over. * Removed some left overs.

Follow up to 5a48451

2f278dd

* Removed references. * Adjusted the instance name search to start to an iterator. * Renamed Maps field to AdditionalMaps. Thanks to @Lemongrass3110 and @secret!

Follow up to 2f278dd

7e5ab49

* Final compile error. * Added database file adjustments.

Corrected a few string to c_str

e1a911e

* Fixed a few instances of string to c_str conversions.

aleos89 added the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label May 29, 2018

aleos89 and others added 5 commits June 13, 2018 16:37

Merge branch 'master' into refactor/instances

37db311

Follow up to 37db311

82c2ee2

* Added new instances.

Converted instance_wait to a deque

80fc0a7

* Allows for quick and dynamic modification. * Reduces memory usage of statically allocated array.

Merge branch 'master' into refactor/instances

bb57d77

# Conflicts: # src/map/instance.cpp # src/map/instance.hpp

Merge branch 'master' into refactor/instances

5831cc4

Atemo reviewed Jun 24, 2018

View reviewed changes

db/import-tmpl/instance_db.yml Outdated Show resolved Hide resolved

aleos89 added 3 commits June 25, 2018 12:43

Added a unique instance name check

61bc5eb

* Instance names should also be unique as they have their own lookup. Thanks to @Atemo!

Follow up to 61bc5eb

3279f92

* Corrected a compile error. * Cleaned up instance enter location parsing.

Corrected duplicate name parsing

eca6e16

Merge branch 'master' into refactor/instances

a1847e6

# Conflicts: # .travis.yml

aleos89 added 5 commits July 16, 2018 12:51

Merge branch 'master' into refactor/instances

acc54cc

Merge branch 'master' into refactor/instances

f2a99ac

Resolved some compile errors

1f0f7e0

Some general refinements

03694ac

Corrected a compile error on GCC

3b52d39

aleos89 mentioned this pull request Jul 28, 2018

instance_create missing exception #3361

Closed

Corrects timer data

cfaefa2

* Follow up to 0476686. Thanks to @ecdarreola!

aleos89 added 3 commits March 30, 2020 15:13

Merge branch 'master' into refactor/instances

7e8d7e2

Updates documentation to point to YAML

a324f2f

Adds Instance name check

df651cb

* Adds a check to make sure Instance names are unique. Thanks to @Atemo!

Converts Additional Maps format

e4f1d72

* Converts the Additional Maps format to support importing. * Fixes an invalid map name check.

aleos89 added 2 commits March 31, 2020 11:01

Creates a safe vector erase utility

efae534

Fixes a compile error

a9302e3

Cleanups of variable type

4e21219

* Adjusts some checks for the change from unsigned short to int of instance_id.

Adds map name length check

4aec65c

* Adds a map name length check when creating unique IDs to not exceed 999. Thanks to @Atemo!

Atemo approved these changes Apr 8, 2020

View reviewed changes

aleos89 merged commit 06c159c into master Apr 8, 2020

aleos89 deleted the refactor/instances branch April 8, 2020 16:52

aleos89 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Apr 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored Instances to utilize C++ features #3163

Refactored Instances to utilize C++ features #3163

aleos89 commented May 27, 2018 •

edited

Loading

ghost commented Jul 1, 2018

aleos89 commented Jul 2, 2018

mjonrest commented Jul 9, 2018

aleos89 commented Jul 10, 2018

mjonrest commented Jul 11, 2018

aleos89 commented Jul 12, 2018

mjonrest commented Jul 12, 2018

lgtm-com bot commented Mar 25, 2020

ecdarreola commented Mar 25, 2020

CairoLee commented Mar 25, 2020

lgtm-com bot commented Mar 30, 2020

lgtm-com bot commented Mar 31, 2020

lgtm-com bot commented Apr 1, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

Chywoner commented Apr 13, 2020

Lemongrass3110 commented Apr 13, 2020

SeravySensei commented May 6, 2020

aleos89 commented May 6, 2020

admkakaroto commented Jun 8, 2020

Atemo commented Jun 8, 2020

aleos89 commented Jun 8, 2020

admkakaroto commented Jun 9, 2020

Refactored Instances to utilize C++ features #3163

Refactored Instances to utilize C++ features #3163

Conversation

aleos89 commented May 27, 2018 • edited Loading

ghost commented Jul 1, 2018

aleos89 commented Jul 2, 2018

mjonrest commented Jul 9, 2018

aleos89 commented Jul 10, 2018

mjonrest commented Jul 11, 2018

aleos89 commented Jul 12, 2018

mjonrest commented Jul 12, 2018

lgtm-com bot commented Mar 25, 2020

ecdarreola commented Mar 25, 2020

CairoLee commented Mar 25, 2020

lgtm-com bot commented Mar 30, 2020

lgtm-com bot commented Mar 31, 2020

lgtm-com bot commented Apr 1, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

Chywoner commented Apr 13, 2020

Lemongrass3110 commented Apr 13, 2020

SeravySensei commented May 6, 2020

aleos89 commented May 6, 2020

admkakaroto commented Jun 8, 2020

Atemo commented Jun 8, 2020

aleos89 commented Jun 8, 2020

admkakaroto commented Jun 9, 2020

aleos89 commented May 27, 2018 •

edited

Loading