Deploy to Azure button #124

jpoon · 2015-11-25T08:17:53Z

What it looks like (feel free to click the button below, it works 🎉 ):

Uses ARM template to create a Standard_A0 sized VM (smallest/cheapest option). Upon startup, the VM will install Docker and run the slackin image. The slackin server will be reachable at {whatever-you-configured-as-your-dns-in-the-setup}.westus.cloudapp.azure.com.

Re: #96

jpoon · 2015-11-25T10:00:40Z

package.json

@@ -11,7 +11,7 @@
    "express": "4.11.0",
    "hostenv": "1.0.1",
    "opentype.js": "0.4.4",
-    "socket.io": "1.3.5",
+    "socket.io": "1.3.6",


1.3.6 addressed a build issue on Windows.

rauchg · 2015-11-30T02:55:19Z

Pushed 0.7.3 bumping socket.io. Is there a way to fix the Azure button to that tag?

jpoon · 2015-11-30T03:08:00Z

Rather than fixing it to a particular tag, the button will deploy the latest version that is available on npm (which is 0.7.3 right now).

rauchg · 2015-11-30T04:10:52Z

Standard_A0 sized VM (smallest/cheapest option)

Is there a free tier like Heroku?

jpoon · 2015-11-30T04:33:26Z

There is a free tier for web apps (PaaS). However, as slackin uses native node modules, we are forced to use virtual machines which does not have a free tier. New Azure signups have $200 credit which would pay for running a slackin instance deployed through this button for about 16 months.

rauchg · 2015-11-30T05:21:57Z

as slackin uses native node modules

We don't depend on them. Any way to force the free tier?

jpoon · 2015-11-30T22:11:39Z

Looks like I'm mistaken. Web apps run node-gyp just fine. However, I think we'll need to tinker with the build as Windows doesn't come preinstalled with gnu make. So either we download/install gnu make on the web app (not even sure if the sandbox will allow me to execute a random exe) or replace the makefile with gulp + babel.

What do you think? Is there a reason why we are using make?

rauchg · 2015-11-30T22:14:26Z

Totally down for ditching make

jpoon · 2015-12-01T19:20:21Z

👍 I'll update the PR (hopefully over the weekend)

jpoon · 2015-12-07T08:29:16Z

Will re-open PR with new changes in a bit.

jpoon · 2015-12-08T07:25:46Z

Here's what it looks like so far with the following implemented:

- Replace Make with Gulp
- Upgrade to Babel6 (Upgrade babel #122)
- Add Deploy to Azure button to readme which deploys master branch to an Azure Web App (on the Free Tier)
- Provide option to deploy a stable release

rauchg · 2015-12-09T22:54:58Z

wow

rauchg · 2015-12-09T22:55:21Z

Provide option to deploy a stable release

this would be awesome. I love reproducible and predictable builds.

jpoon · 2015-12-11T12:08:43Z

I hope that's a good wow 😏
Been slammed at work. Will get around to finishing this off soon.

rauchg · 2015-12-11T16:57:00Z

It was an amazing wow

rauchg · 2015-12-14T16:56:00Z

@jpoon can we also get a retina button (SVG)? The button above looks blurry

jpoon · 2015-12-14T18:16:07Z

They don't seem to have one at the moment: projectkudu/slingshot#28. 😞. In the meantime, as suggested by the bug, we can use a shields.io one.

jpoon · 2015-12-16T01:31:24Z

🎉 All done.

If you press the deploy button, it'll bring you to this screen:

You can choose what Slackin Release you want:

Stable = deploys latest published slackin npm package
Latest = will deploy whatever is in the git repo (e.g. latest code)

After going through the deployment wizard, it'll bring you to this screen:

I manually verified that both stable and latest work. Having deployed our VsCodeVim slackin instance via the Azure button. 😄

Sidenote: As stable installs slacking through npm, we'll need to update the npm package with the gulp/babel build in order for it to work on Windows/Azure. For testing, I had published my own gulpified-slackin version.

rauchg · 2015-12-16T18:44:59Z

Super awesome work.

rauchg · 2015-12-16T18:45:36Z

gulpfile.js

+});
+
+gulp.task('clean', function() {
+	return gulp.src(paths.out_js, { read: false }) 


The indentation doesn't seem to match the project's?

jpoon · 2015-12-16T19:29:41Z

Addressed comments and squashed commits.

rauchg · 2015-12-16T21:19:23Z

My only oustanding concern is how many files we have now for cloud deployment in source control. After this deploy we'll end up with:

app.json
Procfile
Dockerfile
azuredeploy.json
.deployment
deploy.sh
web.config

in order to support Docker, Heroku and Azure.

jpoon · 2015-12-16T22:06:21Z

For each cloud provider, you'd need to define a minimum set of deploy/setup logic regardless. In the case of Azure, I did my best in limiting the amount of files that I need to touch.

Edit: Actually, I might be able to eliminate one file. Testing out my theory. Will update in a sec.

rauchg · 2015-12-16T22:46:44Z

package.json

@@ -29,7 +34,7 @@
  },
  "scripts": {
    "test": "mocha",
-    "postinstall": "make",
-    "start": "./bin/slackin $SLACK_SUBDOMAIN $SLACK_API_TOKEN"
+    "postinstall": "./node_modules/.bin/gulp",


I think you can just write gulp here.

That assumes it is installed globally which may not be the case.

I thought NPM aliased the local binaries as globals for the script declarations?

TIL. Fixed.

rauchg · 2015-12-16T22:47:48Z

gulpfile.js

+             .pipe(rimraf());
+});
+
+gulp.task('default', ['es6to5', 'copyassets']);


The rest of the repo uses ES6. Sticks out a bit

Needed to add a .babelrc but this is now es6.

rauchg · 2015-12-16T22:48:18Z

@jpoon some more comments. Sorry about the extensive review.

rauchg · 2015-12-16T22:55:02Z

re: my comment about the number of files. I was simultaneously ranting about the inherent tradeoff between supporting many cloud providers out-of-the-box and the cleanliness of the project root.

Things like deploy.sh concern me slightly because it's not clear whether it works for deploying anywhere or just for Azure. To the uninitiated, it might raise the question: why is it not npm install && np start? what's deploy.sh?

The fewer the files and the more succinct they are, the better for the project.

jpoon · 2015-12-17T00:30:51Z

Removed .deployment and renamed some stuff to make it a bit more obvious:

azuredeploy.json: used for the wizard to prompt user for their slack/slackin settings
azuredeploy.sh: needed in order to deploy stable. if we wanted to always deploy latest git repo, we can get rid of this.
web.config: azure by default looks for app.js or index.js as a startup file. Telling Azure that it's actually bin\slackin in web.config.

Re: Rant

Yeah, I feel ya... not sure what can be done though.

jpoon · 2016-01-05T07:18:43Z

@rauchg anything else to address to get this merged?

To clean up the root path, we could create a deployment folder and put:

Dockerfile
azureDeploy.sh

Everything else (incl. Heroku Procfile) still needs to be in the root.

rauchg · 2016-01-05T21:33:31Z

Maybe azureDeploy.sh goes into scripts/? Dockerfile in root is fine. Thanks!

jpoon · 2016-01-06T02:25:16Z

@rauchg done! Also:

fixed some babel error/warnings
updated readme to run gulp instead of make

* Uses ARM template to create a Web App (Free Tier) * When deploying, choose between `Latest` (deploys code from git repo) or `Stable` (deploy from latest published npm package). * Server will be accessible at `<sitename>.azurewebsites.net`

rauchg · 2016-01-06T03:16:33Z

gulpfile.babel.js

+             .pipe(rimraf());
+});
+
+gulp.task('default', ['es6to5', 'copyassets']);


this is great, thank you!

Deploy to Azure button

jpoon reviewed Nov 25, 2015
View reviewed changes

jpoon mentioned this pull request Nov 25, 2015

Add Slackin to Readme VSCodeVim/Vim#31

Merged

jpoon closed this Dec 7, 2015

jpoon reopened this Dec 8, 2015

jpoon mentioned this pull request Dec 8, 2015

Slacking on other free clouds? #96

Open

rauchg reviewed Dec 16, 2015
View reviewed changes

Build: Update builds to use gulp and babel6 (Fixes #122)

6dac818

Deploy to Azure Button

51887b2

* Uses ARM template to create a Web App (Free Tier) * When deploying, choose between `Latest` (deploys code from git repo) or `Stable` (deploy from latest published npm package). * Server will be accessible at `<sitename>.azurewebsites.net`

rauchg reviewed Jan 6, 2016
View reviewed changes

gulpfile.babel.js

.pipe(rimraf());

});

gulp.task('default', ['es6to5', 'copyassets']);

Copy link

Owner

rauchg Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you!

rauchg added a commit that referenced this pull request Jan 6, 2016

Merge pull request #124 from jpoon/master

90863ac

Deploy to Azure button

rauchg merged commit 90863ac into rauchg:master Jan 6, 2016

Deploy to Azure button #124

Deploy to Azure button #124

Conversation

jpoon commented Nov 25, 2015

Choose a reason for hiding this comment

rauchg commented Nov 30, 2015

jpoon commented Nov 30, 2015

rauchg commented Nov 30, 2015

jpoon commented Nov 30, 2015

rauchg commented Nov 30, 2015

jpoon commented Nov 30, 2015

rauchg commented Nov 30, 2015

jpoon commented Dec 1, 2015

jpoon commented Dec 7, 2015

jpoon commented Dec 8, 2015

rauchg commented Dec 9, 2015

rauchg commented Dec 9, 2015

jpoon commented Dec 11, 2015

rauchg commented Dec 11, 2015

rauchg commented Dec 14, 2015

jpoon commented Dec 14, 2015

jpoon commented Dec 16, 2015

rauchg commented Dec 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpoon commented Dec 16, 2015

rauchg commented Dec 16, 2015

jpoon commented Dec 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rauchg commented Dec 16, 2015

rauchg commented Dec 16, 2015

jpoon commented Dec 17, 2015

jpoon commented Jan 5, 2016

rauchg commented Jan 5, 2016

jpoon commented Jan 6, 2016

Choose a reason for hiding this comment