Fix form when SLACK_CHANNELS contains only one entry #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am very interesting in fixing this issue, we deployed project on heroku and it does not work with 1 channel :( @rauchg could you please say when you will be able to look into it? Thanks in advance! |
|
Anything we can do to help usher this along? Running into this issue and happy to test. |
|
Merged this PR onto master and is working great. Thanks @nickstenning! |
rauchg
added a commit
that referenced
this pull request
Mar 8, 2016
Fix form when SLACK_CHANNELS contains only one entry
andrewsardone
added a commit
to andrewsardone/slackin
that referenced
this pull request
Mar 10, 2016
Introduced with the merge of rauchg#152, the problem was if the `SLACK_CHANNELS` environment variable wasn't set up, then no hidden form element with the listed channels would be included. Therefore, our `channel` variable would be `undefined`, and a direct access of the `value` property would crash the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e35a05b introduced a problem -- the form sends
channel=nullwhenSLACK_CHANNELScontains only one entry, but the relevant form handler doesn't seem to cope with this scenario.I figured the easiest way to fix this was to inject an
<input type="hidden">in the single-channel case. This seems to work nicely, after a small tweak to the client-side form handler.Fixes #77.