Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-channel config resulting in "Not a permitted channel" #77

Closed
dguido opened this issue Jul 11, 2015 · 14 comments · Fixed by #152
Closed

Single-channel config resulting in "Not a permitted channel" #77

dguido opened this issue Jul 11, 2015 · 14 comments · Fixed by #152

Comments

@dguido
Copy link

dguido commented Jul 11, 2015

I'm running on Heroku and starting slackin like so where $SLACK_CHANNELS is "opensource".

make && bin/slackin --channels "$SLACK_CHANNELS" --port $PORT $SLACK_SUBDOMAIN $SLACK_API_TOKEN

After I start the webapp and attempt to put in any email address, the application errors out and says "Not a permitted channel." I have verified that the Slack API token I gave it comes from an admin. When visiting the index, the correct information is displayed in the browser: "Join My Org #opensource on Slack."

Relevant code appears to be from here:
https://github.com/rauchg/slackin/blob/master/lib/index.js#L33-L40
https://github.com/rauchg/slackin/blob/master/lib/index.js#L82-L98

I'm not certain why this is failing. If this isn't an obvious bug, can you provide some advice for debugging it on my end? Thanks!

@dguido
Copy link
Author

dguido commented Jul 26, 2015

Updated to the latest commit on master today and this is still an issue :-/

@dguido
Copy link
Author

dguido commented Jul 29, 2015

I bothered people at Slack about this issue and they said:

I also must mention that Slackin uses an unpublished/undocumented/private API method to perform the invite itself, and we're unable to support it for public use (supported methods are listed at http://api.slack.com/methods).

Did they silently change the API that slackin was using and that's why it doesn't work anymore?

@matthewford
Copy link

From the readme:

Important: if you use Slackin in single-channel mode, you'll only be able to invite as many external accounts as paying members you have times 5. If you are not getting invite emails, this might be the reason. Workaround: sign up for a free org, and set up Slackin to point to it (all channels will be visible).

@dguido
Copy link
Author

dguido commented Aug 6, 2015

Thanks Matt, I verified that is not the case. I am far under the limit for single-channel guests and I can invite them through the web panel.

@lutoma
Copy link

lutoma commented Dec 7, 2015

Hi, I have the same issue. If I specify multiple channels (resulting in a dropdown menu in the frontend) it works just fine, but with only one channel it fails.

As a workaround I just specified "channelname," which leads to an empty option in the dropdown. It seems to work then.

@StartupBros
Copy link

I also had this problem - @lutoma's solution is working for now. Would be great to get rid of the empty dropdown option though.

@GuGuss
Copy link

GuGuss commented Jan 15, 2016

Same issue here with a single channel.

Running slackin TEAM-ID TOKEN-ID --channels 'CHANNELNAME,' --port $PORT works fine but still displays a dropdown to the user.

@nickstenning
Copy link
Contributor

This looks to me like this bug was introduced by this commit: e35a05b.

The form handler still expects channel to be provided in the POST payload, but the <select> is only rendered if the channel list contains more than one item.

@carmstrong
Copy link

Seeing this issue as well. Happy to deploy master once #152 is merged.

@lutoma Thanks for the workaround!

@GuGuss
Copy link

GuGuss commented Mar 9, 2016

@carmstrong Yay, #152 has been merged!

@carmstrong
Copy link

#152 has been merged!

🍻 And 0.8.3! We can stop using our fork now! :)

@txsteven
Copy link

I'm still seeing this on the Heroku app. Was #152 set to resolve it there also?

@carmstrong
Copy link

I'm still seeing this on the Heroku app.

Are you launching 0.8.3? The badge in the README is still using 0.8.2. Use this link:
https://heroku.com/deploy?template=https://github.com/rauchg/slackin/tree/0.8.3

@rauchg
Copy link
Owner

rauchg commented Mar 14, 2016

@txsteven @carmstrong fixed the Badge. Let me know if it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants