Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add already registered link #80

Merged
merged 3 commits into from
Aug 23, 2015
Merged

Add already registered link #80

merged 3 commits into from
Aug 23, 2015

Conversation

jtatum
Copy link
Contributor

@jtatum jtatum commented Jul 21, 2015

If you wind up back at the page to request an invite and input your address again, slack raises an error because you're already on the team. This adds a link below the signup button to take you back to Slack when you're already registered.

@jtatum
Copy link
Contributor Author

jtatum commented Jul 21, 2015

screen shot of updated form

If you're already invited but haven't signed in, you probably missed the
email from feedback@slack.com. Added an error message about this.

Also, if you're already on the team, you need to go to the signin page.
There's a new link for it but let's output the page in the error message.

Updated styles so multiline errors will display.
@jtatum
Copy link
Contributor Author

jtatum commented Jul 21, 2015

Added some error messages:
already invited

@treeder
Copy link

treeder commented Jul 22, 2015

+1

@rauchg
Copy link
Owner

rauchg commented Jul 24, 2015

I like the error, but I don't like the styling on that message underneath. The link color is extraneous, and there's not enough whitespace between the button and the text. Not sure about the font-size either.

@rauchg
Copy link
Owner

rauchg commented Jul 24, 2015

Thanks again @jtatum

@jtatum
Copy link
Contributor Author

jtatum commented Jul 24, 2015

No worries. I'm awful at design. I knew this was going to be a tough one - slackin's design is so beautiful, and I knew it would be hard to create something that fit 😄 Do you have any suggestions? I can bump up the whitespace. I was thinking the font should be smaller than the text above, but maybe that's wrong?

@sc0ttkclark
Copy link
Contributor

+1 on sign in link for sure!

@rauchg
Copy link
Owner

rauchg commented Aug 14, 2015

Here's a suggestion

screen shot 2015-08-14 at 11 54 38 am

11px Helvetica, #000, link is the same color as the button (#E20761 I believe), 15px separation from the button.

@jtatum
Copy link
Contributor Author

jtatum commented Aug 23, 2015

The color was already the same - both button and p.signin a use the "pink" constant. Looks nicer!
screen shot 2015-08-22 at 5 14 50 pm

@rauchg
Copy link
Owner

rauchg commented Aug 23, 2015

you're amazing – thank you!

rauchg added a commit that referenced this pull request Aug 23, 2015
Add already registered link
@rauchg rauchg merged commit 0bdbc4d into rauchg:master Aug 23, 2015
@jtatum jtatum deleted the alreadyreg branch August 23, 2015 01:07
laughinghan added a commit to laughinghan/slackin that referenced this pull request Feb 27, 2016
Why was it excluded in rauchg#80? With the button that opens the iframe
dialog, there's no link to the landing page, which means with the button
there's no link at all to the actual Slack channel.
@laughinghan
Copy link
Contributor

Any particular reason y'all specifically excluded this already registered link (the "or sign in" link) from the iframe dialog? The button that opens the iframe provides no link to the landing page, so this means that with the button there's no link at all to the actual Slack channel.

I've opened #153 to add this link to the iframe dialog as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants