-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add already registered link #80
Conversation
If you're already invited but haven't signed in, you probably missed the email from feedback@slack.com. Added an error message about this. Also, if you're already on the team, you need to go to the signin page. There's a new link for it but let's output the page in the error message. Updated styles so multiline errors will display.
+1 |
I like the error, but I don't like the styling on that message underneath. The link color is extraneous, and there's not enough whitespace between the button and the text. Not sure about the |
Thanks again @jtatum |
No worries. I'm awful at design. I knew this was going to be a tough one - slackin's design is so beautiful, and I knew it would be hard to create something that fit 😄 Do you have any suggestions? I can bump up the whitespace. I was thinking the font should be smaller than the text above, but maybe that's wrong? |
+1 on sign in link for sure! |
you're amazing – thank you! |
Why was it excluded in rauchg#80? With the button that opens the iframe dialog, there's no link to the landing page, which means with the button there's no link at all to the actual Slack channel.
Any particular reason y'all specifically excluded this already registered link (the "or sign in" link) from the iframe dialog? The button that opens the iframe provides no link to the landing page, so this means that with the button there's no link at all to the actual Slack channel. I've opened #153 to add this link to the iframe dialog as well. |
If you wind up back at the page to request an invite and input your address again, slack raises an error because you're already on the team. This adds a link below the signup button to take you back to Slack when you're already registered.