[core] Remove unused test utils

[edoakes]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @edoakes, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've cleaned up the test_util module by removing several functions and associated global variables that are no longer utilized. This change specifically targets utilities for starting and stopping GCS servers and Raylets, as well as general process killing functions. The aim is to improve code maintainability and reduce the overall codebase size by eliminating dead code, ensuring that the test utilities are lean and relevant to current testing needs.

Highlights

• Removal of GCS Server Test Utilities: The StartGcsServer and StopGcsServer functions, which were part of TestSetupUtil and used for managing GCS server instances in tests, have been removed from both the header and implementation files.
• Removal of Raylet Test Utilities: The StartRaylet and StopRaylet functions, also part of TestSetupUtil and responsible for managing Raylet processes in tests, have been removed from the codebase.
• Removal of Process Killing Utilities: General process killing utilities, KillProcessBySocketName and KillAllExecutable, which were previously available in test_util, have been removed.
• Removal of Unused Test Path Variables and Constants: Several global variables defining paths to test executables (TEST_GCS_SERVER_EXEC_PATH, TEST_RAYLET_EXEC_PATH, TEST_MOCK_WORKER_EXEC_PATH) and a magic constant (SHOULD_CHECK_MESSAGE_ORDER) that were no longer in use have been removed.
• Updated TestSetupUtil Class Documentation: The comment block for the TestSetupUtil class in test_util.h has been updated to accurately reflect its reduced scope, now primarily focusing on Redis server management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes several unused test utility functions and variables from src/ray/common/test_util.cc and src/ray/common/test_util.h. The changes are straightforward deletions of dead code, which improves code maintainability. The removals are consistent across the header and implementation files, and an associated class comment has been updated to reflect the reduced functionality. The changes look good and I see no issues.