[Google translate] Add a preference for the default action #12078
Conversation
raycastbot
added
extension fix / improvement
|
Thank you for your contribution! 🎉 🔔 @gebeto @FezVrasta @ickas @metakirby5 @tangerine1202 @nirtamir2 @pernielsentikaer @rasitayaz you might want to have a look. |
Popalay
changed the title
Popalay
force-pushed
the
google-translate-default-action
branch
from
3be18b6
to
6bfd2e5
Compare
There was a problem hiding this comment.
Hi 👋
Thanks for your contribution 💪
I have now tested your extension, and I have some feedback ready for you 🙂
"include": ["src/**/*", "raycast-env.d.ts"],
I'm looking forward to testing this extension again 🔥
Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.
Popalay
force-pushed
the
google-translate-default-action
branch
from
53f6619
to
8651980
Compare
| @@ -42,16 +43,15 @@ export default function Translate(): ReactElement { | |||
| const tooltip = `${langFrom?.name ?? langFrom?.code} -> ${langTo?.name ?? langTo?.code}`; | |||
|
|
|||
| return ( | |||
| <> | |||
| <React.Fragment key={index}> | |||
There was a problem hiding this comment.
@gebeto Just curious why it's needed here?
There was a problem hiding this comment.
<></> is a shorthand for <React.Fragment></React.Fragment>, when we are assigning the key, we need to use React.Fragment, because we can't do <key={index}>
we need a key right on fragment here because it is an element that we are returning from the map. Key was used on nested elements before, and you could see an error in the console:
More details about key you can get in official react docs here: https://react.dev/learn/rendering-lists
And here is also more details about Fragments and keys: https://react.dev/reference/react/Fragment#rendering-a-list-of-fragments
long story short - key should be applied to the root element which is returning from the map, in this case it is a Fragment
Minor code style fixes.
Popalay
force-pushed
the
google-translate-default-action
branch
from
8651980
to
0c64e0d
Compare
|
@pernielsentikaer I think we are good to merge here 🙌 |
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
This PR adds the ability to specify the default action for the translation:
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder