-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update date-converter extension #12456
Conversation
- feat:add human readable time difference - feat:add 24h format option
Thank you for your contribution! 🎉 🔔 @asportnoy you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. |
- changelog update - feat:add human readable time difference - changelog update - feat:add human readable time difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the relative info be part of the item description maybe? Also does it need to be that detailed?
Better? |
- changelog update - feat:add human readable time difference - changelog update - feat:add human readable time difference
- changelog update - feat:add human readable time difference - changelog update - feat:add human readable time difference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as reviewed again - see above
- Revert "feat:add human readable time difference" - changelog update - feat:add human readable time difference - feat:add 24h format option - changelog update - feat:add human readable time difference - feat:add 24h format option
Reverted the relative time work. I'll use my fork, I guess my needs are very specific. |
We can make it a preferences to show seconds or not, I like the idea 🙂 |
@asportnoy could you check it once again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! One minor thing and then I think it's good to go.
Co-authored-by: Albert Portnoy <albert@albertp.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those changes, looks good to me.
@pernielsentikaer ready to merge when you are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder