Skip to content

Update random-emoji to support old bash #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

Update random-emoji to support old bash #986

merged 1 commit into from
Mar 28, 2025

Conversation

Sixeight
Copy link
Contributor

Description

Old version bash does not support mapfile command, so I've changed to use read .

Type of change

  • New script command
  • Bug fix
  • Improvement of an existing script
  • Documentation update
  • Toolkit change
  • Other (Specify)

Screenshot

Dependencies / Requirements

  • curl
  • jq

Checklist

@Sixeight
Update random-emoji to support old bash
b6fdfb8 
Old version bash does not support `mapfile` command
unnamedd
unnamedd approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the support! It looks good to me.

@unnamedd unnamedd added the accepted PR is ready to be merged label Mar 28, 2025
@giedreblekaite giedreblekaite merged commit e465aa6 into raycast:master Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giedreblekaite giedreblekaite giedreblekaite approved these changes

+1 more reviewer

@unnamedd unnamedd unnamedd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
accepted PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sixeight @unnamedd @giedreblekaite