Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming "LoadCubesmap" #4

Closed
debiatan opened this issue Nov 9, 2014 · 2 comments
Closed

Consider renaming "LoadCubesmap" #4

debiatan opened this issue Nov 9, 2014 · 2 comments

Comments

@debiatan
Copy link
Contributor

debiatan commented Nov 9, 2014

Hi! The issue I'm reporting here is kind of minor. If you find it too picky, feel free to ignore it without a second though.

Cube mapping has a long history in computer graphics and the term is already associated to a different concept than that implied by the raylib codebase.

Although a Cubesmap is not a cube map, the similarity of the names can lead many to confusion (e.g. experienced graphics programmers thinking they can build a skybox from a Cubesmap or novices trained on raylib mistaking its Cubesmaps with anybody else's CubeMaps).

I would suggest LoadCubicMap or LoadMapOfCubes as alternative names to the LoadCubesmap function on src/models.c and src/raylib.h.

Cheers!

@debiatan debiatan changed the title Consider renaming "cubes maps" Consider renaming "LoadCubesmap" Nov 9, 2014
@raysan5
Copy link
Owner

raysan5 commented Nov 9, 2014

Hi debiatan! Completely agree with you, I face the same dilemma when choosing the name; actually, first name for the function was LoadCubicmap, I change it later...

This function still requires some work (like some other 3d functions), I'll change its name once completed.

Thank you very much for your help!

@debiatan
Copy link
Contributor Author

debiatan commented Nov 9, 2014

Glad to know the name is not set in stone!

@debiatan debiatan closed this as completed Nov 9, 2014
raysan5 pushed a commit that referenced this issue Aug 30, 2018
michaelfiber referenced this issue in michaelfiber/raylib Sep 21, 2023
Cleaned up menu navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants