-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming "LoadCubesmap" #4
Comments
debiatan
changed the title
Consider renaming "cubes maps"
Consider renaming "LoadCubesmap"
Nov 9, 2014
Hi debiatan! Completely agree with you, I face the same dilemma when choosing the name; actually, first name for the function was This function still requires some work (like some other 3d functions), I'll change its name once completed. Thank you very much for your help! |
Glad to know the name is not set in stone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! The issue I'm reporting here is kind of minor. If you find it too picky, feel free to ignore it without a second though.
Cube mapping has a long history in computer graphics and the term is already associated to a different concept than that implied by the raylib codebase.
Although a
Cubesmap
is not a cube map, the similarity of the names can lead many to confusion (e.g. experienced graphics programmers thinking they can build a skybox from a Cubesmap or novices trained on raylib mistaking its Cubesmaps with anybody else's CubeMaps).I would suggest
LoadCubicMap
orLoadMapOfCubes
as alternative names to theLoadCubesmap
function onsrc/models.c
andsrc/raylib.h
.Cheers!
The text was updated successfully, but these errors were encountered: