[build] CMake: support OpenGL ES3 in LibraryConfigurations.cmake
#4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter0x44
suggested changes
Jun 19, 2024
cmake/LibraryConfigurations.cmake
Outdated
| if(NOT GRAPHICS) | ||
| set(GRAPHICS "GRAPHICS_API_OPENGL_ES2") | ||
| elseif(${GRAPHICS} MATCHES "GRAPHICS_API_OPENGL_ES3") | ||
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -sFULL_ES3=1") |
There was a problem hiding this comment.
For GLFW this is put in target_link_options, rather than CMAKE_EXE_LINKER_FLAGS.
Could you do that instead?
There was a problem hiding this comment.
I guess it's better, yes
raysan5
changed the title
LibraryConfigurations.cmake
|
LGTM! approved. |
|
Actually, one last nit: Change that and all should be fine. |
|
@Peter0x44 ouch! just merged to quickly, please @manuel5975p send a patch |
|
Doesn't another part of the emscripten doc say that -sOPTION is exactly equivalent to -sOPTION=1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only put ES2 as a fallback if
GRAPHICSis not specified.